chore: remove local Keychain repair wrapper#412
Conversation
rianjs
force-pushed
the
fix/delegate-keychain-repair-to-cli-common
branch
from
5158eb9 to
67baddd
Compare
rianjs
changed the title
Automated PR ReviewReviewed commit: Summary
documentation:docs (1 finding)Major -
|
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| automation:ci-release | complete_broad | .github/workflows/ci.yml, Makefile, scripts/README.md, scripts/repair-codereview-keychain-acl.sh | unavailable | Review limited to the assigned automation-related files and repo-local guidance. |
| policies:conventions | complete_broad | .github/workflows/ci.yml, Makefile, docs/development.md, scripts/README.md | unavailable | Review limited to the assigned changed files and the repo-local guidance available in this checkout.; The sibling ../cli-common and ../.github convenience copies referenced by repo docs were not present here, so shared-policy checks were based only on the repo's visible source-of-truth/linking conventions. |
| documentation:docs | complete_broad | docs/development.md, scripts/README.md | unavailable | Review scoped to the assigned documentation files and repo-local context; optional sibling repositories like ../cli-common were not assumed to be checked out. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 29s | unavailable | gpt-5.4 | cr 0.10.202
| Field | Value |
|---|---|
| Model | gpt-5.4 |
| Reviewers | automation:ci-release, policies:conventions, documentation:docs |
| Engine | codex_cli · gpt-5.4 |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 1m 29s wall · 3m 04s compute |
| Cost | unavailable |
| Tokens | 218.2k in / 8.8k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.4 | 12.8k | 561 | 7.6k | unavailable | unavailable | 12s |
| automation:ci-release | gpt-5.4 | 64.1k | 2.1k | 28.8k | unavailable | unavailable | 44s |
| policies:conventions | gpt-5.4 | 72.6k | 3.0k | 57.3k | unavailable | unavailable | 59s |
| documentation:docs | gpt-5.4 | 57.3k | 2.8k | 40.6k | unavailable | unavailable | 58s |
| orchestrator-rollup | gpt-5.4 | 11.4k | 236 | 7.6k | unavailable | unavailable | 9s |
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
|
|
||
| Default mode is a dry-run: | ||
| macOS Keychain credential ACL repair is shared across the Open CLI Collective | ||
| tool family. Use the canonical helper from the sibling `cli-common` checkout: |
There was a problem hiding this comment.
This README now tells readers to run ../cli-common/scripts/repair-macos-keychain-credentials.sh, but that path only works when an optional sibling cli-common checkout exists. Repo guidance explicitly treats sibling repos as convenience copies, not something docs can assume, so the example becomes a broken local reference for anyone working from a standalone codereview-cli clone. Document the prerequisite explicitly and add a canonical source-of-truth link or alternate retrieval path (for example, 'if ../cli-common is checked out, run ...; otherwise fetch it from open-cli-collective/cli-common').
Reply inline to this comment.
There was a problem hiding this comment.
Fixed - clarified the canonical cli-common source and made the sibling checkout path optional.
There was a problem hiding this comment.
Confirmed. The README now treats the sibling ../cli-common checkout as optional and points readers to the canonical open-cli-collective/cli-common source when that local path is unavailable.
Summary:
Docs no longer assume a sibling cli-common checkout exists. The README now marks that path as optional and directs standalone clones to the canonical open-cli-collective/cli-common source instead.
Automated PR ReviewReviewed commit: Summary
Reviewer Coverage
1 PR discussion threads considered. 1 summarized; 1 resolved. Completed in 2m 02s | unavailable | gpt-5.4 | cr 0.10.202
Per-workstream usage
|
1 participant
Summary
Dependency
Validation