chore: Add E2E test for path server demos - #44
Open
arjo129 wants to merge 2 commits into
Open
Conversation
Currently our tests do not exercise the path_server_demo. This has lead to regressions when testing (particularly with DDS) as our integration tests may pass but the first demo which people try is broken. In this test we check the REST endpoints of the demo correctly integrate with the rest of the system. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Contributor
|
@SamuelFoo please review |
Contributor
|
The changes look good but maybe we need to specify (I don't seem to have the option to submit a review, so I’m leaving this as a comment.) |
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Member
Author
Thanks for catching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our tests do not exercise the path_server_demo. This has lead
to regressions when testing (particularly with DDS) as our integration tests
may pass but the first demo which people try is broken. In this test we
check the REST endpoints of the demo correctly integrate with the rest
of the system.
GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: