Gate PeriodicMetricReader self-observability by internal telemetry version#8597
Open
Debashismitra01 wants to merge 1 commit into
Open
Conversation
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8597 +/- ##
============================================
+ Coverage 91.62% 91.63% +0.01%
- Complexity 10321 10325 +4
============================================
Files 1013 1013
Lines 27287 27295 +8
Branches 3203 3203
============================================
+ Hits 25001 25012 +11
+ Misses 1559 1558 -1
+ Partials 727 725 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
PeriodicMetricReaderwith anInternalTelemetryVersion.MetricExporterConfigurationto propagate the configured telemetry version when creatingPeriodicMetricReader.PeriodicMetricReaderBuildertoInternalTelemetryVersion.LATEST.Why?
PeriodicMetricReaderalways emittedotel.sdk.metric_reader.collection.durationwhenever a realMeterProviderwas available, regardless ofOTEL_EXPERIMENTAL_SDK_TELEMETRY_VERSION.Tracing and logging already gate SDK self-observability using
InternalTelemetryConfiguration.getVersion(config). This change aligns metric reader self-observability with the existing behavior while preserving the default behavior for direct SDK users.Fixes #8566