OBPIH-7920 Putaway - add comment to putaway#95
Open
kkrawczyk123 wants to merge 6 commits into
Open
Conversation
alannadolny
reviewed
Jul 3, 2026
Comment on lines
+51
to
+61
| get commentContent() { | ||
| return this.row.getByRole('cell').nth(2); | ||
| } | ||
|
|
||
| get recipientContent() { | ||
| return this.row.getByRole('cell').nth(0); | ||
| } | ||
|
|
||
| get senderContent() { | ||
| return this.row.getByRole('cell').nth(1); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why not just comment, recipient and sender?
| } | ||
|
|
||
| get recipientDropdown() { | ||
| return this.page.locator('#recipient_id_chosen .chosen-single'); |
| } | ||
|
|
||
| get recipientOptions() { | ||
| return this.page.locator('#recipient_id_chosen .chosen-results li'); |
|
|
||
| get orderNumberValue() { | ||
| return this.page.locator( | ||
| '[data-testid=\'wizardTitle\'] > div > span:nth-of-type(2)' |
Collaborator
There was a problem hiding this comment.
:(((((((((((((((((((( Can you make something like byDataTestId and then check if this container has a child?
Comment on lines
+167
to
+170
| await expect(putawayDetailsPage.badgeCount).toHaveAttribute( | ||
| 'data-count', | ||
| '1' | ||
| ); |
Comment on lines
+320
to
+323
| putawayListPage.table.rowByOrderNumber( | ||
| `${putawayOrderIdentifier}`.toString().trim() | ||
| ).orderNumber | ||
| ).toContainText(`${putawayOrderIdentifier}`); |
Collaborator
There was a problem hiding this comment.
You can assign the duplicated value to a const and then assert it shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added: