Track OpenCode 1.18.12 - #7
Merged
Merged
Conversation
OpenChamber moved to SDK 1.18.12 while this package still asked for plugin API 1.18.8, whose own SDK dependency is 1.18.8. Two versions of the same SDK in one dependency tree stopped the Electron package from building at all: the packager walks production dependencies and could not resolve the nested one. The workspace surface is unchanged across those releases — the v2 client, the generated SDK and the generated types carry the same workspace API and types, so nothing in this package had to adapt. The runtime image tracks the same version, so the CLI inside a workspace matches the API the host talks to.
`@opencode-ai/plugin` appears exactly once in this package, as an `import type` in `src/plugin.d.ts`. No runtime code loads it. Declaring it under `dependencies` made it part of every consumer's production tree, so the Electron packager walked it and demanded its transitive SDK — which, once OpenChamber moved to 1.18.12 while this package asked for 1.18.8, could not be resolved and stopped the package from building at all. Aligning the versions removes today's mismatch; moving the dependency removes the reason a mismatch could break packaging in the first place. This package now ships no production dependencies, which is what a plugin loaded by its host should look like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
OpenChamber moved to SDK 1.18.12; this package still asked for plugin API 1.18.8, whose own SDK dependency is 1.18.8.
Two versions of the same SDK in one dependency tree stopped the Electron package from building: the packager walks production dependencies and could not resolve the nested one.
Safety
The workspace surface is unchanged across these releases. Compared 1.18.8 with 1.18.12:
dist/v2/client.d.ts— identical workspace APIdist/gen/sdk.gen.d.ts— identicaldist/v2/gen/types.gen.d.ts— identical workspace typesNothing in this package had to adapt. The runtime image tracks the same version, so the OpenCode CLI inside a workspace matches the API the host talks to.
Tests
Unchanged: the same three Windows-only suites fail before and after (symlinks, POSIX modes), green in Linux CI.