fix: apply status and date filters together with AND for catalog actitvities - #68
Merged
Merged
Conversation
|
jordivx
requested review from
hrcornejo,
ivan-risueno,
sergio-esperalta-bi and
sergio-soria-bi
August 3, 2026 14:47
sergio-esperalta-bi
approved these changes
Aug 4, 2026
| filteredCatalogActivities = filterOutByStatus(filteredCatalogActivities, status); | ||
| } | ||
|
|
||
| if (startDate != null && endDate != null) { |
Contributor
There was a problem hiding this comment.
What happens when we have only startDate or only endDate? Is it correct to do nothing?
Contributor
Author
There was a problem hiding this comment.
Indeed, I just kept the previous behavior just "nesting" the filters, but keeping the same conditions, dates were meant to be a range, if is only one of the values, the filter is not applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates catalog activity filtering so start and end date constraints are no longer skipped when status is provided, ensuring combined filters behave consistently with project filtering, and adds a regression test to verify that project, status, and date range together return only activities that satisfy all selected criteria.