Skip to content

fix(verawood): limit assignable roles to the user's manage-team permissions #177

Merged
arbrandes merged 1 commit into
openedx:release/verawoodfrom
eduNEXT:dcoa/limit-bp
Jul 14, 2026
Merged

fix(verawood): limit assignable roles to the user's manage-team permissions #177
arbrandes merged 1 commit into
openedx:release/verawoodfrom
eduNEXT:dcoa/limit-bp

Conversation

@dcoa

@dcoa dcoa commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR backports the changes in #172 to the verawood release branch.

…enedx#172)

* fix: validate user manage team action and scopes

* fix: filter roles displays only the user scope related

* refactor: add a teams manage variable
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 3, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (12b5783) to head (5c8fc9b).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/verawood     #177      +/-   ##
====================================================
+ Coverage             97.64%   97.70%   +0.05%     
====================================================
  Files                    68       69       +1     
  Lines                  1572     1611      +39     
  Branches                396      408      +12     
====================================================
+ Hits                   1535     1574      +39     
  Misses                   37       37              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the backport! LGTM

Here's what I tested after building with tutor my Verawood environment using this branch:

  1. As a Django admin, I can see the assign roles button. I can also see all roles in the assignment wizard
  2. As a regular user, I can only see the assign roles button when I have a (course/library) admin
  3. As a regular user, I can only see library/course roles in the assignment wizzard where I have a library/course admin role
  4. As a regular admin, If I have at least an admin role then I see the assignment button but only with the role I have admin on

I also made sure we were only including already approved changes. Thanks again!

@arbrandes arbrandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: this matches what landed in master.

@arbrandes
arbrandes merged commit 9d2a741 into openedx:release/verawood Jul 14, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

5 participants