fix(verawood): limit assignable roles to the user's manage-team permissions #177
Conversation
…enedx#172) * fix: validate user manage team action and scopes * fix: filter roles displays only the user scope related * refactor: add a teams manage variable
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/verawood #177 +/- ##
====================================================
+ Coverage 97.64% 97.70% +0.05%
====================================================
Files 68 69 +1
Lines 1572 1611 +39
Branches 396 408 +12
====================================================
+ Hits 1535 1574 +39
Misses 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks a lot for the backport! LGTM
Here's what I tested after building with tutor my Verawood environment using this branch:
- As a Django admin, I can see the assign roles button. I can also see all roles in the assignment wizard
- As a regular user, I can only see the assign roles button when I have a (course/library) admin
- As a regular user, I can only see library/course roles in the assignment wizzard where I have a library/course admin role
- As a regular admin, If I have at least an admin role then I see the assignment button but only with the role I have admin on
I also made sure we were only including already approved changes. Thanks again!
arbrandes
left a comment
There was a problem hiding this comment.
Approved: this matches what landed in master.
This PR backports the changes in #172 to the verawood release branch.