fix: correct fallback handling for email opt-in report#38410
Open
ajayakkalasetti wants to merge 1 commit into
Open
fix: correct fallback handling for email opt-in report#38410ajayakkalasetti wants to merge 1 commit into
ajayakkalasetti wants to merge 1 commit into
Conversation
ajayakkalasetti
force-pushed
the
fix/email-optin-report-fallback-values
branch
from
April 22, 2026 14:14
8b5dfe7 to
fa866c0
Compare
jsnwesson
approved these changes
Jul 14, 2026
ajayakkalasetti
force-pushed
the
fix/email-optin-report-fallback-values
branch
from
July 18, 2026 06:45
fa866c0 to
36b542b
Compare
ajayakkalasetti
marked this pull request as ready for review
July 18, 2026 07:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect fallback behavior in the Email Opt-In report where users without an email preference record were assigned misleading default values.
Problem
The report currently assigns:
is_opted_in_for_email = "True"(hardcoded)preference_set_datetime = "2014-12-01 00:00:00"(hardcoded default)when no corresponding record exists in
user_api_userorgtag.Solution
Removed the hardcoded fallback date
Avoid defaulting
is_opted_in_for_emailto"True"Instead:
preference_set_datetimeempty when no value existsis_opted_in_for_emailempty when no preference is setAmal please take a look on it.