Skip to content

Remove system-defined taxonomies, CONTENT_TAGGING_AUTO#38895

Open
bradenmacdonald wants to merge 3 commits into
openedx:masterfrom
open-craft:braden/remove-taxonomy-extra
Open

Remove system-defined taxonomies, CONTENT_TAGGING_AUTO#38895
bradenmacdonald wants to merge 3 commits into
openedx:masterfrom
open-craft:braden/remove-taxonomy-extra

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

This PR, along with openedx/openedx-core#654 (which must merge first), will:

  • Remove "system defined" taxonomies. The only one was the "Languages" taxonomy and we don't believe anyone was using it. However, if someone was using it, it will be converted to a regular taxonomy and continue to work.
  • Remove the "auto tagging" feature that tags every XBlock with the language of the parent course. This was another half-baked feature and its waffle flag was off by default. I don't believe anyone ever used it.
  • Implements the "read_only" flag for taxonomies, which makes their tags not editable in the UI (other metadata continues to be editable).
  • Improves some tests and fixes some flakiness
  • Fixes what seems like a major issue in the API: the tag_object API would silently fail if the taxonomy was not enabled for the org that owns the content you are trying to tag. As a result, a couple of test cases were not even testing what they thought, because the tags never got created in the first place.

Supporting information

Implements openedx/openedx-core#634

Testing instructions

Verify that the taxonomy editor and content tagging features are working as normal.

Sandbox: https://studio.pr-38895-885846.axim-sandboxes.opencraft.hosting/

Deadline

None

@bradenmacdonald bradenmacdonald added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jul 16, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 16, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald
bradenmacdonald force-pushed the braden/remove-taxonomy-extra branch from dd9ff31 to 7b4c37c Compare July 16, 2026 23:07
@@ -0,0 +1,122 @@
"""

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was renamed from test_tasks.py. Most of the code was existing code, but I removed all the tests related to auto-tagging and only left in the tests related to auto-deleting tags when the content gets deleted.

@kaustavb12 kaustavb12 added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants