Skip to content

feat: allow library linked problem edits#38901

Open
asadali145 wants to merge 1 commit into
openedx:masterfrom
mitodl:asad/allow-library-linked-problem-to-be-edited
Open

feat: allow library linked problem edits#38901
asadali145 wants to merge 1 commit into
openedx:masterfrom
mitodl:asad/allow-library-linked-problem-to-be-edited

Conversation

@asadali145

Copy link
Copy Markdown
Contributor

Description

Problem block edit should be allowed when used from a V2 Library. When editing a problem block in the library, we don't see certain course-specific fields, and they were meant to be allowed to be edited in the course. All of this was discussed in openedx/frontend-app-authoring#1317.

Due to changes in #36553 and #37124, it only allowed HTML/Text blocks to be edited in the course. This PR adds back the problem in the allowlist. It is understood that resyncing upstream will erase problem content changes and fields that are meant to be synced.

Supporting information

openedx/frontend-app-authoring#1317
#37124
#36553

Testing instructions

  • Checkout master branch
  • Create a V2 library and a problem block in it.
  • Notice that fields like scoring are not available in the editor.
  • Create a course and use a problem from the library.
  • Click on the edit icon and notice it only allows you to edit the title of the problem and does not open the editor.
  • Check out this branch, and the editor should open when you try to edit the block in the course.
  • You should see extra fields like scoring and be able to change those. Change some of the scoring settings.
  • Go back to the library and make changes to the problem content.
  • Sync the problem block in the course and verify that changes are synced with the library and scoring field settings remain the same as changed.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @asadali145!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 17, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 17, 2026
@asadali145

Copy link
Copy Markdown
Contributor Author

@kdmccormick @bradenmacdonald @navinkarkera Can you please take a look at this PR?

CC: @jmakowski1123

@asadali145 asadali145 changed the title feat: allow library linked problem edit feat: allow library linked problem edits Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants