-
Notifications
You must be signed in to change notification settings - Fork 7
build: Modernize xapi-db-load: migrate to uv, pyproject.toml, PEP 735 dependency groups #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
farhan
wants to merge
8
commits into
openedx:main
Choose a base branch
from
farhan:farhan/modernize-python-repos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
69c55e8
build: migrate to uv, pyproject.toml, and PEP 735 dependency groups
farhan 84fbac6
build: add quality and docs envs to CI matrix
farhan b50cf32
build: remove unnecessary source-tracing comments from pyproject.toml
farhan b20ffef
fix: resolve tox -e docs failures
farhan c2cc8bb
chore: regenerate pylintrc with edx-lint 6.1.0
farhan 774f0c7
style: enforce multi-line import formatting via isort force_grid_wrap
farhan 8254898
fix: make tox -e quality pass for pre-existing code
farhan ab21d6d
fix: resolve pre-existing pylint violations at source
farhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,41 @@ | ||
| name: Run all tests & checks | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [ main ] | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| run_tests: | ||
| name: tests | ||
| name: ${{ matrix.toxenv }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| python-version: [ '3.12' ] | ||
| permissions: | ||
| # Gives the action the necessary permissions for publishing new | ||
| # comments in pull requests. | ||
| pull-requests: write | ||
| # Gives the action the necessary permissions for pushing data to the | ||
| # python-coverage-comment-action branch, and for editing existing | ||
| # comments (to avoid publishing multiple comments in the same PR) | ||
| contents: write | ||
| python-version: ["3.12"] | ||
| toxenv: [py, quality, docs] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - name: setup python | ||
| uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 | ||
| - name: Checkout repository | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@11f9893b081a58869d3b5fccaea48c9e9e46f990 # v8.3.2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| enable-cache: true | ||
| python-version: "${{ matrix.python-version }}" | ||
|
|
||
| - name: Install pip | ||
| run: pip install -r requirements/pip.txt | ||
| - name: Install CI dependencies | ||
| run: uv sync --group ci | ||
|
|
||
| - name: Install Dependencies | ||
| run: pip install -r requirements/ci.txt | ||
| - name: Run tox | ||
| run: uv run tox -e ${{ matrix.toxenv }} | ||
|
|
||
| - name: Run Tests | ||
| run: tox | ||
| - name: Upload coverage to Codecov | ||
| if: matrix.toxenv == 'py' && matrix.python-version == '3.12' | ||
| uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v6.0.2 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| flags: unittests | ||
| fail_ci_if_error: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| include CHANGELOG.rst | ||
| include LICENSE.txt | ||
| include README.rst | ||
| include requirements/base.in | ||
| include requirements/constraints.txt | ||
| recursive-include xapi-db-load *.html *.png *.gif *.js *.css *.jpg *.jpeg *.svg *.csv | ||
| recursive-include xapi_db_load *.html *.png *.gif *.js *.css *.jpg *.jpeg *.svg *.csv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| xapi\_db\_load.fixtures package | ||
| =============================== | ||
|
|
||
| Submodules | ||
| ---------- | ||
|
|
||
| xapi\_db\_load.fixtures.music\_tags module | ||
| ------------------------------------------ | ||
|
|
||
| .. automodule:: xapi_db_load.fixtures.music_tags | ||
| :members: | ||
| :show-inheritance: | ||
| :undoc-members: | ||
|
|
||
| Module contents | ||
| --------------- | ||
|
|
||
| .. automodule:: xapi_db_load.fixtures | ||
| :members: | ||
| :show-inheritance: | ||
| :undoc-members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tool installs happen globally. We should just be including tox in the
devdependency group.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we do include tox in the dev group. So this should be fully unnecessary.