Normalize path output for --dump-includes - #307
Conversation
|
Hi @xpple, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xpple" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@xpple This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
Seems a sensible fix -- thanks. Is there a test we can add? |
78d0b71 to
6eb8d1d
Compare
|
@xpple Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
I don't know why the test is failing, it is identical in structure to |
This PR normalizes the path output for
--dump-includes.--dump-includesmay not be normalized. For example, the output could be:grepto filter based on known paths to header files.normalize()call inIncludeHelper.java.I didn't test the PR locally using jtreg, but the tests on GitHub Actions ran successfully. I did also confirm that the new output correctly normalizes each path:
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/307/head:pull/307$ git checkout pull/307Update a local copy of the PR:
$ git checkout pull/307$ git pull https://git.openjdk.org/jextract.git pull/307/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 307View PR using the GUI difftool:
$ git pr show -t 307Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/307.diff
Using Webrev
Link to Webrev Comment