agent: handle GUI unavailable when gathering logs after install#1919
Open
zaneb wants to merge 1 commit into
Open
agent: handle GUI unavailable when gathering logs after install#1919zaneb wants to merge 1 commit into
zaneb wants to merge 1 commit into
Conversation
After a successful installation the rendezvous node reboots to join the cluster, so the Assisted Installer GUI is no longer running. Use the non-panicking browser.Page() instead of browser.MustPage() so that a connection refused error is caught and logged gracefully rather than causing a panic. Assisted-by: Claude Code
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful installation the rendezvous node reboots to join the cluster, so the Assisted Installer GUI is no longer running. Use the non-panicking browser.Page() instead of browser.MustPage() so that a connection refused error is caught and logged gracefully rather than causing a panic.