Skip to content

WIP: frr-k8s: Replace privileged SCC with custom frr-k8s SCC - #3078

Open
oribon wants to merge 1 commit into
openshift:masterfrom
oribon:frrk8s_scc
Open

WIP: frr-k8s: Replace privileged SCC with custom frr-k8s SCC#3078
oribon wants to merge 1 commit into
openshift:masterfrom
oribon:frrk8s_scc

Conversation

@oribon

@oribon oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The frr-k8s DaemonSet and node-status-cleaner Deployment were using the broad privileged SCC. Replace it with a purpose-built SCC that grants only the capabilities required for BGP routing (NET_RAW, NET_ADMIN, SYS_ADMIN, NET_BIND_SERVICE) plus hostNetwork/hostPorts access.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f0a2c6e9-1abb-412a-b33d-d670d4d6f681

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from arkadeepsen and mattedallo July 21, 2026 10:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@oribon

oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/test ci/prow/frrk8s-e2e

@oribon

oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oribon
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@oribon

oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@oribon

oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@oribon

oribon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

1 similar comment
@oribon

oribon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@oribon

oribon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

2 similar comments
@oribon

oribon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@oribon

oribon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@oribon

oribon commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@oribon

oribon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@oribon

oribon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

The frr-k8s DaemonSet and node-status-cleaner Deployment were using the
broad privileged SCC. Replace it with a purpose-built SCC that grants
only the capabilities required for BGP routing (NET_RAW, NET_ADMIN,
SYS_ADMIN, NET_BIND_SERVICE) plus hostNetwork/hostPorts access.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
@oribon

oribon commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

/test frr-k8s
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@oribon

oribon commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw

@oribon

oribon commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

/test frrk8s-e2e

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@oribon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade 69f89ee link false /test 5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw 69f89ee link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade 69f89ee link false /test 5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp 69f89ee link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-upgrade 69f89ee link false /test 5.0-upgrade-from-stable-4.22-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant