Skip to content

CONSOLE-5398: Remove events card from node overview dashboard#16697

Open
jeff-phillips-18 wants to merge 1 commit into
openshift:mainfrom
jeff-phillips-18:node-remove-events-card
Open

CONSOLE-5398: Remove events card from node overview dashboard#16697
jeff-phillips-18 wants to merge 1 commit into
openshift:mainfrom
jeff-phillips-18:node-remove-events-card

Conversation

@jeff-phillips-18

Copy link
Copy Markdown
Member

Closes CONSOLE-5398

Note
This feature is available in Tech Preview only.

Analysis / Root cause:
The Node overview dashboard needed to remove the Events/Activity card to streamline the UI when the FLAG_NODE_MGMT_V1 feature flag is enabled.

Solution description:

  • Added conditional rendering in NodeDashboard to hide the Activity card when FLAG_NODE_MGMT_V1 is enabled
  • Enhanced DashboardGrid to support optional left and right card columns with dynamic main grid span calculation
  • Added comprehensive RTL tests for DashboardGrid (7 tests) and NodeDashboard (5 tests)
  • Enhanced InventoryCard tests with feature flag path validation
  • Updated InventoryCard to use correct pod navigation path based on feature flag (workload tab path vs legacy path)
  • Fixed import path for NodeGroupEditButton in NodesPage to avoid barrel imports

Screenshots / screen recording:

*** With tech-preview ***
image

*** Without tech-preview ***
image

Test setup:

  1. Ensure you have a cluster in tech preview mode with the FLAG_NODE_MGMT_V1 feature flag available
  2. Navigate to Compute → Nodes → Select a node → Overview tab

Test cases:

  • When FLAG_NODE_MGMT_V1 is enabled, verify Activity card is not visible in the Overview dashboard
  • Verify main cards expand to full width when Activity card is hidden
  • Verify Details and Inventory cards remain visible regardless of flag state
  • Click on Pods in Inventory card and verify navigation goes to /k8s/cluster/nodes/{name}/workload/pods when flag is enabled
  • When FLAG_NODE_MGMT_V1 is disabled, verify Activity card appears in the right column (legacy behavior)
  • Verify pod navigation uses legacy path /k8s/cluster/nodes/{name}/pods when flag is disabled
  • Verify DashboardGrid adapts layout correctly when cards are conditionally hidden

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
This change maintains backward compatibility by conditionally showing the Activity card based on the feature flag state. The DashboardGrid component now intelligently adapts its layout to provide optimal space utilization when side columns are absent.

Reviewers and assignees:
Console Approver:
/assign @jhadvig

Docs approver:
/assign @jseseCCS

PX approver:
/assign @rh-joshbeverly

🤖 Generated with https://claude.com/claude-code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@jeff-phillips-18: This pull request references CONSOLE-5398 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.0." or "openshift-5.0.", but it targets "openshift-4.23" instead.

Details

In response to this:

Closes CONSOLE-5398

Note
This feature is available in Tech Preview only.

Analysis / Root cause:
The Node overview dashboard needed to remove the Events/Activity card to streamline the UI when the FLAG_NODE_MGMT_V1 feature flag is enabled.

Solution description:

  • Added conditional rendering in NodeDashboard to hide the Activity card when FLAG_NODE_MGMT_V1 is enabled
  • Enhanced DashboardGrid to support optional left and right card columns with dynamic main grid span calculation
  • Added comprehensive RTL tests for DashboardGrid (7 tests) and NodeDashboard (5 tests)
  • Enhanced InventoryCard tests with feature flag path validation
  • Updated InventoryCard to use correct pod navigation path based on feature flag (workload tab path vs legacy path)
  • Fixed import path for NodeGroupEditButton in NodesPage to avoid barrel imports

Screenshots / screen recording:

*** With tech-preview ***
image

*** Without tech-preview ***
image

Test setup:

  1. Ensure you have a cluster in tech preview mode with the FLAG_NODE_MGMT_V1 feature flag available
  2. Navigate to Compute → Nodes → Select a node → Overview tab

Test cases:

  • When FLAG_NODE_MGMT_V1 is enabled, verify Activity card is not visible in the Overview dashboard
  • Verify main cards expand to full width when Activity card is hidden
  • Verify Details and Inventory cards remain visible regardless of flag state
  • Click on Pods in Inventory card and verify navigation goes to /k8s/cluster/nodes/{name}/workload/pods when flag is enabled
  • When FLAG_NODE_MGMT_V1 is disabled, verify Activity card appears in the right column (legacy behavior)
  • Verify pod navigation uses legacy path /k8s/cluster/nodes/{name}/pods when flag is disabled
  • Verify DashboardGrid adapts layout correctly when cards are conditionally hidden

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
This change maintains backward compatibility by conditionally showing the Activity card based on the feature flag state. The DashboardGrid component now intelligently adapts its layout to provide optimal space utilization when side columns are absent.

Reviewers and assignees:
Console Approver:
/assign @jhadvig

Docs approver:
/assign @jseseCCS

PX approver:
/assign @rh-joshbeverly

🤖 Generated with https://claude.com/claude-code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from rawagner and sg00dwin July 1, 2026 16:07
@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Jul 1, 2026
@jeff-phillips-18

Copy link
Copy Markdown
Member Author

/test backend

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@jeff-phillips-18: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vojtechszocs

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2026
@rh-joshbeverly

Copy link
Copy Markdown

/label px-approved

@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants