NO-ISSUE: Match operator lifecycle versions by major.minor only

[joelanford]

Analysis / Root cause:
findVersionEntry tried an exact version string match before falling back to major.minor matching. The lifecycle data spec (REQ-VER-01) requires version names to be strictly MAJOR.MINOR format, so the exact-match path was unnecessary — the minor version match always did the real work.

Solution description:
Simplified findVersionEntry in operator-lifecycle-status.tsx to match solely on major.minor using parseMinorVersion(), removing the redundant exact-match attempt. This aligns the implementation with the lifecycle data spec.

Screenshots / screen recording:
N/A — logic-only change with no visual impact.

Test setup:
No special setup required.

Test cases:

• Existing tests in operator-lifecycle-status.spec.tsx continue to pass
• Version matching by minor version (e.g., operator version 1.0.5 matches lifecycle version 1.0)

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:
N/A

Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Lifecycle status matching now consistently resolves the applicable lifecycle entry using the operator’s minor version.
  • For unparseable operator versions, compatibility now reports “no-data” and the support phase returns “No Data,” preventing misleading results.

• Tests

  • Added test coverage for unparseable operator version inputs to validate the expected “no-data” and “No Data” behavior.

[openshift-ci-robot]

@joelanford: This pull request explicitly references no jira issue.

Details

In response to this:

Analysis / Root cause:
findVersionEntry tried an exact version string match before falling back to major.minor matching. The lifecycle data spec (REQ-VER-01) requires version names to be strictly MAJOR.MINOR format, so the exact-match path was unnecessary — the minor version match always did the real work.

Solution description:
Simplified findVersionEntry in operator-lifecycle-status.tsx to match solely on major.minor using parseMinorVersion(), removing the redundant exact-match attempt. This aligns the implementation with the lifecycle data spec.

Screenshots / screen recording:
N/A — logic-only change with no visual impact.

Test setup:
No special setup required.

Test cases:

• Existing tests in operator-lifecycle-status.spec.tsx continue to pass
• Version matching by minor version (e.g., operator version 1.0.5 matches lifecycle version 1.0)

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

Additional info:
N/A

Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f6793924-ca96-47b1-bd02-51571617cd89

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf9127 and 1759484.

📒 Files selected for processing (2)

• frontend/packages/operator-lifecycle-manager/src/components/__tests__/operator-lifecycle-status.spec.tsx
• frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

• frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx
• frontend/packages/operator-lifecycle-manager/src/components/tests/operator-lifecycle-status.spec.tsx

---

Walkthrough

The operator lifecycle status lookup now matches lifecycle entries by parsed minor version only, and tests cover unparseable operator version inputs for compatibility and support phase results.

Changes

Operator lifecycle version matching

Layer / File(s)	Summary
Minor-version matching and invalid input handling frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx, frontend/packages/operator-lifecycle-manager/src/components/__tests__/operator-lifecycle-status.spec.tsx	findVersionEntry now returns undefined when the operator version cannot be parsed and otherwise matches entries by parsed minor version; tests assert "no-data" and SupportPhaseStatus.NoData for unparseable versions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: TheRealJon, jseseCCS

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: matching operator lifecycle versions by major.minor only.
Description check	✅ Passed	The description covers the required sections and explains the root cause, solution, tests, and non-visual impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The added Ginkgo/Jest test titles are static and descriptive; none include dynamic values like dates, UUIDs, node/namespace names, or generated suffixes.
Test Structure And Quality	✅ Passed	PASS: The modified spec is plain Jest unit tests for pure helper functions; no Ginkgo, cluster resources, waits, or cleanup concerns are present.
Microshift Test Compatibility	✅ Passed	PR only changes frontend TypeScript logic and Jest unit tests; no new Ginkgo e2e tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The only added tests are Jest unit tests in a frontend component file; no Ginkgo/e2e tests or SNO/HA assumptions were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	Only lifecycle version parsing and tests changed; no manifests, controllers, or scheduling/topology logic were added.
Ote Binary Stdout Contract	✅ Passed	Changed files only adjust version matching and add unit tests; no main/init/TestMain/BeforeSuite stdout writes or stdout logging APIs were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The changed test file is a Jest unit spec, not a Ginkgo e2e test, and it adds no IPv4 hardcoding or external network calls.
No-Weak-Crypto	✅ Passed	The PR only changes lifecycle version matching/tests; no weak crypto, custom crypto, or non-constant-time secret comparisons were introduced.
Container-Privileges	✅ Passed	The PR only changes TSX component/test files; no K8s/container manifests or privilege settings like privileged, hostPID, or allowPrivilegeEscalation are present.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files contain no console/log statements or sensitive-data patterns; the PR only changes version matching and adds tests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx`:
- Around line 57-58: The version lookup in operator-lifecycle-status is too
permissive when parseMinorVersion(operatorVersion) returns undefined, because
versions.find with parseMinorVersion(v.name) === minor can incorrectly match
another malformed entry. Update the logic around parseMinorVersion and the
versions.find predicate to first check that minor is defined, and return
undefined immediately when operatorVersion cannot be parsed so only valid
MAJOR.MINOR comparisons are performed.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0c9e7caa-5346-4893-8dc2-11caef4b08d6

📥 Commits

Reviewing files that changed from the base of the PR and between c49aa59 and 48d1480.

📒 Files selected for processing (1)

• frontend/packages/operator-lifecycle-manager/src/components/operator-lifecycle-status.tsx

[joelanford]

/test backend

[perdasilva]

/lgtm

[perdasilva]

Docs Approver:
cc @jseseCCS

PX Approver:
cc @rh-joshbeverly

[rh-joshbeverly]

/label px-approved

[jseseCCS]

1 comment. please review, apply; conditionally approved!

[jseseCCS]

/label docs-approved

[perdasilva]

/hold to address docs review comments

[perdasilva]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joelanford, jseseCCS, perdasilva
Once this PR has been reviewed and has the lgtm label, please assign vikram-raj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@joelanford: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	1759484	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.