Skip to content

OCPBUGS-94055: Fix CVE-2026-13676 fast-uri Unicode hostname canonicalization bypass#16705

Open
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix/CVE-2026-13676
Open

OCPBUGS-94055: Fix CVE-2026-13676 fast-uri Unicode hostname canonicalization bypass#16705
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix/CVE-2026-13676

Conversation

@jrangelramos

@jrangelramos jrangelramos commented Jul 2, 2026

Copy link
Copy Markdown
Member

Analysis / Root cause

fast-uri versions 2.3.1 through 3.1.2 and 4.0.0 fail to canonicalize Unicode (IDN) hostnames for HTTP-family URLs (CVE-2026-13676). The IDN conversion path calls a helper that does not exist on the global URL constructor, silently leaving the host in its original Unicode form while normalize() and equal() still return values that differ from a WHATWG-compatible URL parser. Applications that use fast-uri to enforce host-based policy (denylists, loopback filtering, redirect validation, outbound proxy routing) before passing the same URL to Node's URL or fetch can be bypassed when the two implementations resolve the same input to different hosts.

The package is a transitive dependency pulled in by:

  • ajv@8.17.1fast-uri@3.1.2

There was already a yarn resolution pinning fast-uri at 3.1.2 — the vulnerable version.

Solution description

Bump fast-uri from 3.1.2 to 3.1.3 in the yarn resolutions of frontend/package.json. Version 3.1.3 adds proper IDN conversion for HTTP-family URLs, ensuring Unicode hostnames are correctly canonicalized.

This follows the existing pattern used for other CVE resolution overrides (shell-quote, protobufjs, decode-uri-component, etc.).

Test cases

  • yarn install completes without errors
  • Development build (webpack --mode=development) succeeds
  • Unit test results identical before and after the change (1 failed suite / 9 failed tests — pre-existing swagger.spec.ts failures unrelated to this change)

Additional info

Summary by CodeRabbit

  • Chores
    • Updated a package resolution for fast-uri to a newer patch version.

…ization bypass

Bump fast-uri from 3.1.2 to 3.1.3 via yarn resolutions to fix a
security policy bypass where Unicode (IDN) hostnames are not properly
canonicalized, allowing host-based policy enforcement to be bypassed.
Version 3.1.3 adds proper IDN conversion for HTTP-family URLs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request references Jira Issue OCPBUGS-94055, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause

fast-uri versions 2.3.1 through 3.1.2 and 4.0.0 fail to canonicalize Unicode (IDN) hostnames for HTTP-family URLs (CVE-2026-13676). The IDN conversion path calls a helper that does not exist on the global URL constructor, silently leaving the host in its original Unicode form while normalize() and equal() still return values that differ from a WHATWG-compatible URL parser. Applications that use fast-uri to enforce host-based policy (denylists, loopback filtering, redirect validation, outbound proxy routing) before passing the same URL to Node's URL or fetch can be bypassed when the two implementations resolve the same input to different hosts.

The package is a transitive dependency pulled in by:

  • ajv@8.17.1fast-uri@3.1.2

There was already a yarn resolution pinning fast-uri at 3.1.2 — the vulnerable version.

Solution description

Bump fast-uri from 3.1.2 to 3.1.3 in the yarn resolutions of frontend/package.json. Version 3.1.3 adds proper IDN conversion for HTTP-family URLs, ensuring Unicode hostnames are correctly canonicalized.

This follows the existing pattern used for other CVE resolution overrides (shell-quote, protobufjs, decode-uri-component, etc.).

Test cases

  • yarn install completes without errors
  • Development build (webpack --mode=development) succeeds
  • Unit test results identical before and after the change (1 failed suite / 9 failed tests — pre-existing swagger.spec.ts failures unrelated to this change)

Additional info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from fsgreco and sg00dwin July 2, 2026 19:08
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cfc88a76-e53d-48ea-8680-7c918c170542

📥 Commits

Reviewing files that changed from the base of the PR and between 7707540 and b4427a1.

⛔ Files ignored due to path filters (1)
  • frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • frontend/package.json

Walkthrough

This change updates the fast-uri package resolution version in frontend/package.json from 3.1.2 to 3.1.3.

Changes

Dependency Version Bump

Layer / File(s) Summary
Update fast-uri resolution
frontend/package.json
Bumped the fast-uri resolution entry from version 3.1.2 to 3.1.3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the fast-uri CVE fix and matches the change set.
Description check ✅ Passed The description covers root cause, solution, tests, and extra context; only non-critical template sections are left blank.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only updates frontend/package.json’s fast-uri resolution; no test files or Ginkgo/Jest titles were added or changed.
Test Structure And Quality ✅ Passed Only frontend/package.json changed; no Ginkgo test files or test logic were modified, so the check is not applicable.
Microshift Test Compatibility ✅ Passed PR only bumps fast-uri in frontend/package.json; no new Ginkgo e2e tests or MicroShift-sensitive APIs/features are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only bumps fast-uri in frontend/package.json; no new Ginkgo/e2e tests were added, so SNO compatibility is not impacted.
Topology-Aware Scheduling Compatibility ✅ Passed Only frontend/package.json resolution changed (fast-uri 3.1.3); no manifests, controllers, or scheduling logic were modified.
Ote Binary Stdout Contract ✅ Passed PR changes only frontend/package.json fast-uri resolution; no process-level binary code or stdout writes were modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates frontend/package.json and frontend/yarn.lock; no Ginkgo e2e tests or network-related test code were added or changed.
No-Weak-Crypto ✅ Passed Only change is the fast-uri resolution in frontend/package.json; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code was added.
Container-Privileges ✅ Passed Only frontend/package.json changed; no container/K8s manifests or privileged settings were added.
No-Sensitive-Data-In-Logs ✅ Passed Only a fast-uri resolution bump and lockfile update were changed; no log statements or sensitive-data patterns were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request references Jira Issue OCPBUGS-94055, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Analysis / Root cause

fast-uri versions 2.3.1 through 3.1.2 and 4.0.0 fail to canonicalize Unicode (IDN) hostnames for HTTP-family URLs (CVE-2026-13676). The IDN conversion path calls a helper that does not exist on the global URL constructor, silently leaving the host in its original Unicode form while normalize() and equal() still return values that differ from a WHATWG-compatible URL parser. Applications that use fast-uri to enforce host-based policy (denylists, loopback filtering, redirect validation, outbound proxy routing) before passing the same URL to Node's URL or fetch can be bypassed when the two implementations resolve the same input to different hosts.

The package is a transitive dependency pulled in by:

  • ajv@8.17.1fast-uri@3.1.2

There was already a yarn resolution pinning fast-uri at 3.1.2 — the vulnerable version.

Solution description

Bump fast-uri from 3.1.2 to 3.1.3 in the yarn resolutions of frontend/package.json. Version 3.1.3 adds proper IDN conversion for HTTP-family URLs, ensuring Unicode hostnames are correctly canonicalized.

This follows the existing pattern used for other CVE resolution overrides (shell-quote, protobufjs, decode-uri-component, etc.).

Test cases

  • yarn install completes without errors
  • Development build (webpack --mode=development) succeeds
  • Unit test results identical before and after the change (1 failed suite / 9 failed tests — pre-existing swagger.spec.ts failures unrelated to this change)

Additional info

Summary by CodeRabbit

  • Chores
  • Updated a package resolution for fast-uri to a newer patch version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console b4427a1 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants