Skip to content

OCPBUGS-99199: Add networking.k8s.io group policy#579

Open
dfajmon wants to merge 1 commit into
openshift:mainfrom
dfajmon:OCPBUGS-99199
Open

OCPBUGS-99199: Add networking.k8s.io group policy#579
dfajmon wants to merge 1 commit into
openshift:mainfrom
dfajmon:OCPBUGS-99199

Conversation

@dfajmon

@dfajmon dfajmon commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/OCPBUGS-99199

Add networking.k8s.io/networkpolicies RBAC to the aws-efs CSV to pass the olm.required_network_policy_rbac_for_operands Conforma check, which becomes a release blocker on August 8th.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dfajmon: This pull request references Jira Issue OCPBUGS-99199, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-99199

Add networking.k8s.io/networkpolicies RBAC to the aws-efs CSV to pass the olm.required_network_policy_rbac_for_operands Conforma check, which becomes a release blocker on August 8th.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 36d4c7c1-0c63-4147-a0df-7caf5b071fee

📥 Commits

Reviewing files that changed from the base of the PR and between 1f64834 and 45ab422.

📒 Files selected for processing (1)
  • config/aws-efs/manifests/stable/aws-efs-csi-driver-operator.clusterserviceversion.yaml

📝 Walkthrough

Walkthrough

The AWS EFS operator ClusterServiceVersion now grants its installed ClusterRole permission to create, delete, and update networkpolicies in the networking.k8s.io API group.

Suggested reviewers: dobsonj

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding networking.k8s.io RBAC for the AWS EFS operator CSV.
Description check ✅ Passed The description accurately describes the RBAC change and the Conforma check it is meant to satisfy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CSV manifest changed; no test files or Ginkgo titles were added or modified.
Test Structure And Quality ✅ Passed Only a CSV manifest changed; no Ginkgo test files or test code were modified, so the test-structure review is not applicable.
Microshift Test Compatibility ✅ Passed Only the AWS EFS CSV manifest changed; no Ginkgo/e2e tests or test files were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a CSV RBAC manifest changed; no Ginkgo/e2e tests were added or modified, so there’s no SNO compatibility issue to flag.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only adds networking.k8s.io/networkpolicies RBAC; it does not modify replicas, affinity, node selectors, tolerations, or PDBs.
Ote Binary Stdout Contract ✅ Passed PR only adds RBAC in a CSV manifest; no process-level Go code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a CSV manifest changed; no Ginkgo tests or network code were added, so the IPv4/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed The only change is a YAML RBAC rule for networking.k8s.io/networkpolicies; no weak-crypto tokens or custom crypto code are present.
Container-Privileges ✅ Passed Diff only adds networkpolicies RBAC; no hostPID/hostNetwork/hostIPC, privileged:true, SYS_ADMIN, root, or allowPrivilegeEscalation:true. Existing container secContext is hardened.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds NetworkPolicy RBAC in a CSV manifest; no logging code or new sensitive data exposure appears in the diff.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from rhrmo and stephenfin July 20, 2026 15:25
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@mpatlasov

Copy link
Copy Markdown
Contributor

/lgtm
/verified by mpatlasov

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mpatlasov: This PR has been marked as verified by mpatlasov.

Details

In response to this:

/lgtm
/verified by mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1f64834 and 2 for PR HEAD 45ab422 in total

@dfajmon

dfajmon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@dfajmon

dfajmon commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1da4798 and 1 for PR HEAD 45ab422 in total

@mpatlasov

Copy link
Copy Markdown
Contributor

/retest-required

@dfajmon

dfajmon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-ovn-upgrade

@dfajmon

dfajmon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

3 similar comments
@dfajmon

dfajmon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@dfajmon

dfajmon commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required

@mpatlasov

Copy link
Copy Markdown
Contributor

/retest-required

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-e2e-aks 45ab422 link false /test hypershift-e2e-aks
ci/prow/e2e-aws-ovn-upgrade 45ab422 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants