STOR-2914: Bump all deps for 5.0.0#582
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@rhrmo: This pull request references STOR-2914 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "5.0.0" version, but multiple target versions were set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
📝 WalkthroughWalkthroughUpdates the Go toolchain to 1.26.0, refreshes direct and indirect dependencies across AWS, OpenShift, Prometheus, Kubernetes, observability, OpenAPI, gRPC, and protobuf modules, and switches the EFS volume image build and runtime stages to OpenShift 5.0 images. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)Dockerfile.create_efsTraceback (most recent call last): Comment |
|
/retest-required |
1 similar comment
|
/retest-required |
|
ci/prow/images is failing with |
ima throw a wrench in the CI's server... |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
Dockerfile.create_efs (2)
6-13: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winDefine a container health status.
This Dockerfile has no
HEALTHCHECK, violating the container requirements. Add a meaningful executable probe, or explicitly useHEALTHCHECK NONEif this one-shot image cannot support health probing.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.create_efs` around lines 6 - 13, Define a container health status in the Dockerfile for the image built around the create-efs-volume ENTRYPOINT: add a meaningful executable HEALTHCHECK probe if this one-shot workload supports probing, otherwise explicitly declare HEALTHCHECK NONE.Source: Path instructions
6-13: 🔒 Security & Privacy | 🟠 Major | ⚡ Quick winRun the runtime image as a non-root user.
The final image declares no
USER, so/usr/bin/create-efs-volumeinherits the base image’s root user. Add the project-approved non-root UID and verify that the manifest output paths remain writable.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.create_efs` around lines 6 - 13, Update the final image definition around the ENTRYPOINT to declare the project-approved non-root UID instead of inheriting root. Ensure the copied manifest output directory remains writable by that UID, adjusting its ownership or permissions as needed while preserving create-efs-volume startup.Sources: Path instructions, Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Dockerfile.create_efs`:
- Around line 6-13: Define a container health status in the Dockerfile for the
image built around the create-efs-volume ENTRYPOINT: add a meaningful executable
HEALTHCHECK probe if this one-shot workload supports probing, otherwise
explicitly declare HEALTHCHECK NONE.
- Around line 6-13: Update the final image definition around the ENTRYPOINT to
declare the project-approved non-root UID instead of inheriting root. Ensure the
copied manifest output directory remains writable by that UID, adjusting its
ownership or permissions as needed while preserving create-efs-volume startup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 58197ab4-4bf9-4aaf-98f7-a6a748c7d667
📒 Files selected for processing (1)
Dockerfile.create_efs
|
/lgtm |
|
Scheduling required tests: |
|
/retest |
|
@rhrmo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
go get -u ./...