Revert "STOR-2997: Minimal implementation of GCP PD CSI driver operator" by redhat-chai-bot · Pull Request #583 · openshift/csi-operator

redhat-chai-bot · 2026-07-23T15:26:45Z

This reverts the merge commit 1da4798 (PR #576).

Reason

PR #576 introduced a race condition in the GCP PD CSI driver controller RBAC setup that causes SCC validation failures during cluster installation. The new deployment creates controller pods requiring the hostnetwork-v2 SCC, but the replacement ClusterRoleBinding (gcp-pd-controller-hostnetwork-binding) may not be propagated to the API server RBAC cache before pods are scheduled. During this window, the service account has no SCC access, causing repeated failures:

unable to validate against any security context constraint:
provider "hostnetwork-v2": Forbidden: not usable by user or serviceaccount

This is causing payload-level regression in 5.0 CI, specifically failing the [sig-auth][Feature:SCC][Early] should not have pod creation failures during install test on GCP.

Impact

Test pass rate dropped from 100% (4.22 baseline) to 92.06% (5.0)
Blocking payload verification jobs (e.g. aggregated-gcp-ovn-upgrade-5.0-micro)

Tracking

Jira: OCPBUGS-99490
Original PR: STOR-2997: Minimal implementation of GCP PD CSI driver operator #576

/label trt-incident

@petr-muller requested in Slack thread

…lement-GCP-PD-CSI-driver-operator-inside-csi-operator-framework" This reverts commit 1da4798, reversing changes made to 1f64834.

openshift-merge-bot · 2026-07-23T15:26:48Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-07-23T15:26:49Z

@redhat-chai-bot: The label(s) /label trt-incident cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, verified, ready-for-human-review, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/skip-dependent-bug-check, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

This reverts the merge commit 1da4798 (PR #576).

Reason

PR #576 introduced a race condition in the GCP PD CSI driver controller RBAC setup that causes SCC validation failures during cluster installation. The new deployment creates controller pods requiring the hostnetwork-v2 SCC, but the replacement ClusterRoleBinding (gcp-pd-controller-hostnetwork-binding) may not be propagated to the API server RBAC cache before pods are scheduled. During this window, the service account has no SCC access, causing repeated failures:
unable to validate against any security context constraint:
provider "hostnetwork-v2": Forbidden: not usable by user or serviceaccount
This is causing payload-level regression in 5.0 CI, specifically failing the [sig-auth][Feature:SCC][Early] should not have pod creation failures during install test on GCP.

Impact

Test pass rate dropped from 100% (4.22 baseline) to 92.06% (5.0)

Blocking payload verification jobs (e.g. aggregated-gcp-ovn-upgrade-5.0-micro)

Tracking

Jira: OCPBUGS-99490

Original PR: STOR-2997: Minimal implementation of GCP PD CSI driver operator #576

/label trt-incident

@petr-muller requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-07-23T15:26:50Z

@redhat-chai-bot: This pull request references STOR-2997 which is a valid jira issue.

Details

In response to this:

This reverts the merge commit 1da4798 (PR #576).

Reason

PR #576 introduced a race condition in the GCP PD CSI driver controller RBAC setup that causes SCC validation failures during cluster installation. The new deployment creates controller pods requiring the hostnetwork-v2 SCC, but the replacement ClusterRoleBinding (gcp-pd-controller-hostnetwork-binding) may not be propagated to the API server RBAC cache before pods are scheduled. During this window, the service account has no SCC access, causing repeated failures:
unable to validate against any security context constraint:
provider "hostnetwork-v2": Forbidden: not usable by user or serviceaccount
This is causing payload-level regression in 5.0 CI, specifically failing the [sig-auth][Feature:SCC][Early] should not have pod creation failures during install test on GCP.

Impact

Test pass rate dropped from 100% (4.22 baseline) to 92.06% (5.0)

Blocking payload verification jobs (e.g. aggregated-gcp-ovn-upgrade-5.0-micro)

Tracking

Jira: OCPBUGS-99490

Original PR: STOR-2997: Minimal implementation of GCP PD CSI driver operator #576

/label trt-incident

@petr-muller requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-23T15:26:57Z

Warning

Review limit reached

@redhat-chai-bot, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e2e419d-dfa2-4e80-903a-40e73afb28c0

📥 Commits

Reviewing files that changed from the base of the PR and between 1da4798 and f1d77b4.

⛔ Files ignored due to path filters (33)

assets/overlays/gcp-pd/generated/standalone/cabundle_cm.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller_hostnetwork_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller_pdb.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/controller_sa.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/csidriver.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/hostnetwork_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/kube_rbac_proxy_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/kube_rbac_proxy_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/lease_leader_election_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/lease_leader_election_rolebinding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_attacher_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/main_snapshotter_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/manifests.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node_privileged_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/node_sa.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/privileged_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/prometheus_role.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/prometheus_rolebinding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/service.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass_hyperdisk_balanced.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass_reader_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/storageclass_ssd.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumeattributesclass_reader_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumeattributesclass_reader_resizer_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshot_reader_provisioner_binding.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshotclass.yaml is excluded by !**/generated/**
assets/overlays/gcp-pd/generated/standalone/volumesnapshotclass_images.yaml is excluded by !**/generated/**

📒 Files selected for processing (11)

Dockerfile.gcp-pd
assets/overlays/gcp-pd/custom/old_controller_privileged_binding.yaml
cmd/gcp-pd-csi-driver-operator/main.go
pkg/driver/gcp-pd/custom_labels_test.go
pkg/driver/gcp-pd/custom_resource_tags_test.go
pkg/driver/gcp-pd/gcp_pd.go
pkg/driver/gcp-pd/storageclass_test.go
pkg/driver/gcp-pd/storageclasshook_test.go
pkg/generated-assets/generated_assets.go
pkg/operator/config/config.go
pkg/operator/starter.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-07-23T15:27:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign mpatlasov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-07-23T19:02:00Z

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/aws-efs-sts-cross-account-operator-e2e	`f1d77b4`	link	false	`/test aws-efs-sts-cross-account-operator-e2e`
ci/prow/aws-efs-operator-e2e	`f1d77b4`	link	true	`/test aws-efs-operator-e2e`
ci/prow/smb-win2022-operator-e2e	`f1d77b4`	link	false	`/test smb-win2022-operator-e2e`
ci/prow/smb-operator-e2e-extended	`f1d77b4`	link	false	`/test smb-operator-e2e-extended`
ci/prow/smb-win2019-operator-e2e	`f1d77b4`	link	false	`/test smb-win2019-operator-e2e`
ci/prow/aws-efs-operator-e2e-extended	`f1d77b4`	link	false	`/test aws-efs-operator-e2e-extended`
ci/prow/aws-efs-single-zone-operator-e2e-extended	`f1d77b4`	link	false	`/test aws-efs-single-zone-operator-e2e-extended`
ci/prow/aws-efs-single-zone-cross-account-operator-e2e	`f1d77b4`	link	true	`/test aws-efs-single-zone-cross-account-operator-e2e`
ci/prow/aws-efs-cross-account-operator-e2e	`f1d77b4`	link	false	`/test aws-efs-cross-account-operator-e2e`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

redhat-chai-bot · 2026-07-23T19:03:36Z

/retest-required

mpatlasov · 2026-07-23T20:27:45Z

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview

openshift-ci · 2026-07-23T20:27:55Z

@mpatlasov: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f755cc60-86d4-11f1-9478-69fe50af0ee3-0

mpatlasov · 2026-07-24T03:28:19Z

This revert only hides existing long-standing issue. I'd suggest to merge #584 instead.

redhat-chai-bot · 2026-07-24T12:31:15Z

/hold

Holding this revert in favor of the forward fix in #584 (authored by @mpatlasov). The maintainer's fix is a narrower, targeted change that addresses the root cause (static asset ordering) without reverting the entire GCP PD driver implementation.

The revert remains open as a fallback — if the forward fix doesn't land soon or introduces unexpected issues, we can unhold and merge this instead to unblock payloads.

Revert "Merge pull request openshift#576 from mpatlasov/STOR-2997-Imp…

f1d77b4

…lement-GCP-PD-CSI-driver-operator-inside-csi-operator-framework" This reverts commit 1da4798, reversing changes made to 1f64834.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2026

openshift-ci Bot requested review from jsafrane and mandre July 23, 2026 15:27

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2026

Uh oh!

Conversation

redhat-chai-bot commented Jul 23, 2026

Reason

Impact

Tracking

Uh oh!

openshift-merge-bot Bot commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Reason

Impact

Tracking

Uh oh!

openshift-ci-robot commented Jul 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason

Impact

Tracking

Uh oh!

coderabbitai Bot commented Jul 23, 2026

Review limit reached

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

redhat-chai-bot commented Jul 23, 2026

Uh oh!

mpatlasov commented Jul 23, 2026

Uh oh!

openshift-ci Bot commented Jul 23, 2026

Uh oh!

mpatlasov commented Jul 24, 2026

Uh oh!

redhat-chai-bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

openshift-ci-robot commented Jul 23, 2026 •

edited by openshift-ci Bot

Loading