-
Notifications
You must be signed in to change notification settings - Fork 35
Update test to v1.62.0 #2282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
red-hat-konflux
wants to merge
1
commit into
main
Choose a base branch
from
konflux/mintmaker/main/test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Update test to v1.62.0 #2282
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/lightspeed-console
Length of output: 691
🌐 Web query:
Playwright Docker image version must match@playwright/testversion docker docs💡 Result:
Yes, the version of the Playwright Docker image must match the version of the
@playwright/testpackage used in your project [1][2]. Official documentation explicitly states that it is recommended to pin both the Playwright version in your project and the Docker image tag to specific, identical versions [1][3]. If the Playwright version in your Docker image does not match the version installed in your project, Playwright will be unable to locate the necessary browser executables, which often leads to runtime errors [1][2]. Key considerations include: 1. Consistency: Because Playwright's browser binaries are tied to specific versions of the library, the Docker image—which comes pre-configured with these specific binaries—must align with the library version used in your code [1][4]. 2. Version Drift: Hardcoding image tags in CI configuration files can lead to "version drift," where your project updates its dependency (e.g., via npm) but the Docker image remains on an older, incompatible version [5][3]. 3. Recommended Practice: Always update the Docker image tag and your project's dependency version in tandem [3]. Some developers use dynamic CI configurations to resolve the image version directly from their package lockfile to ensure they are always in sync [5]. The official Playwright Docker images use semantic versioning tags (e.g.,:v1.62.0-noble) to facilitate this pairing [1][6]. Using the latest tag is not supported, as it can cause instability if the package and image versions do not align perfectly [3].Citations:
Align the Playwright image with
@playwright/test. Both Tekton steps usemcr.microsoft.com/playwright:v1.62.0-noble, but the repo still pins@playwright/test(and the lockfile) to1.61.1. Update the test package/lockfile to1.62.0or downgrade the image tov1.61.1-noble.🤖 Prompt for AI Agents