Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .tekton/integration-tests/lightspeed-console-pre-commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
env:
- name: COMMIT_SHA
value: $(params.commit)
image: mcr.microsoft.com/playwright:v1.61.1-noble
image: mcr.microsoft.com/playwright:v1.62.0-noble
resources:
limits:
memory: 4Gi
Expand Down Expand Up @@ -202,7 +202,7 @@ spec:
resources:
limits:
memory: 8Gi
image: mcr.microsoft.com/playwright:v1.61.1-noble
image: mcr.microsoft.com/playwright:v1.62.0-noble

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n '"`@playwright/test`"|"playwright":|mcr\.microsoft\.com/playwright:v' \
  package.json package-lock.json .tekton/integration-tests/lightspeed-console-pre-commit.yaml

Repository: openshift/lightspeed-console

Length of output: 691


🌐 Web query:

Playwright Docker image version must match @playwright/test version docker docs

💡 Result:

Yes, the version of the Playwright Docker image must match the version of the @playwright/test package used in your project [1][2]. Official documentation explicitly states that it is recommended to pin both the Playwright version in your project and the Docker image tag to specific, identical versions [1][3]. If the Playwright version in your Docker image does not match the version installed in your project, Playwright will be unable to locate the necessary browser executables, which often leads to runtime errors [1][2]. Key considerations include: 1. Consistency: Because Playwright's browser binaries are tied to specific versions of the library, the Docker image—which comes pre-configured with these specific binaries—must align with the library version used in your code [1][4]. 2. Version Drift: Hardcoding image tags in CI configuration files can lead to "version drift," where your project updates its dependency (e.g., via npm) but the Docker image remains on an older, incompatible version [5][3]. 3. Recommended Practice: Always update the Docker image tag and your project's dependency version in tandem [3]. Some developers use dynamic CI configurations to resolve the image version directly from their package lockfile to ensure they are always in sync [5]. The official Playwright Docker images use semantic versioning tags (e.g.,:v1.62.0-noble) to facilitate this pairing [1][6]. Using the latest tag is not supported, as it can cause instability if the package and image versions do not align perfectly [3].

Citations:


Align the Playwright image with @playwright/test. Both Tekton steps use mcr.microsoft.com/playwright:v1.62.0-noble, but the repo still pins @playwright/test (and the lockfile) to 1.61.1. Update the test package/lockfile to 1.62.0 or downgrade the image to v1.61.1-noble.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.tekton/integration-tests/lightspeed-console-pre-commit.yaml at line 205,
Align the Playwright container image with the repository’s `@playwright/test`
dependency by choosing one consistent version: update `@playwright/test` and its
lockfile entries to 1.62.0, or change both Tekton Playwright image references to
v1.61.1-noble. Ensure the image and package versions match.

script: |
echo "$KUBECONFIG_VALUE" > /credentials/kubeconfig
echo "COMMIT_SHA: ${COMMIT_SHA}"
Expand Down