Skip to content

refactor: rename RAG reference in tests #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raptorsun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: rename RAG reference in tests #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions internal/controller/appserver/assets_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,9 +1136,9 @@ var _ = Describe("App server assets", func() {
It("should generate RAG volume and initContainers", func() {
cr.Spec.OLSConfig.RAG = []olsv1alpha1.RAGSpec{
{
IndexPath: "/rag/vector_db/ocp_product_docs/4.19",
IndexID: "ocp-product-docs-4_19",
Image: "rag-ocp-product-docs:4.19",
IndexPath: "/rag/vector_db/internal_runbooks/1.0",
IndexID: "internal-runbooks-1_0",
Image: "rag-internal-runbooks:1.0",
},
{
IndexPath: "/rag/vector_db/ansible_docs/2.18",
Expand All @@ -1160,8 +1160,8 @@ var _ = Describe("App server assets", func() {
utils.GeneratePostgresWaitInitContainer(testReconcilerInstance.GetPostgresImage()),
corev1.Container{
Name: "rag-0",
Image: "rag-ocp-product-docs:4.19",
Command: []string{"sh", "-c", fmt.Sprintf("mkdir -p %s/rag-0 && cp -a /rag/vector_db/ocp_product_docs/4.19/. %s/rag-0", utils.RAGVolumeMountPath, utils.RAGVolumeMountPath)},
Image: "rag-internal-runbooks:1.0",
Command: []string{"sh", "-c", fmt.Sprintf("mkdir -p %s/rag-0 && cp -a /rag/vector_db/internal_runbooks/1.0/. %s/rag-0", utils.RAGVolumeMountPath, utils.RAGVolumeMountPath)},
VolumeMounts: []corev1.VolumeMount{
{
Name: utils.RAGVolumeName,
Expand Down Expand Up @@ -1189,9 +1189,9 @@ var _ = Describe("App server assets", func() {
By("additional RAG indexes are added")
cr.Spec.OLSConfig.RAG = []olsv1alpha1.RAGSpec{
{
IndexPath: "/rag/vector_db/ocp_product_docs/4.19",
IndexID: "ocp-product-docs-4_19",
Image: "rag-ocp-product-docs:4.19",
IndexPath: "/rag/vector_db/internal_runbooks/1.0",
IndexID: "internal-runbooks-1_0",
Image: "rag-internal-runbooks:1.0",
},
{
IndexPath: "/rag/vector_db/ansible_docs/2.18",
Expand All @@ -1207,9 +1207,9 @@ var _ = Describe("App server assets", func() {

Expect(olsconfigGenerated.OLSConfig.ReferenceContent.Indexes).To(Equal([]utils.ReferenceIndex{
{
ProductDocsIndexId: "ocp-product-docs-4_19",
ProductDocsIndexId: "internal-runbooks-1_0",
ProductDocsIndexPath: utils.RAGVolumeMountPath + "/rag-0",
ProductDocsOrigin: "rag-ocp-product-docs:4.19",
ProductDocsOrigin: "rag-internal-runbooks:1.0",
},
{
ProductDocsIndexId: "ansible-docs-2_18",
Expand Down
6 changes: 3 additions & 3 deletions internal/controller/appserver/deployment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ var _ = Describe("App server deployment generation", func() {
It("should generate RAG volumes and initContainers", func() {
cr.Spec.OLSConfig.RAG = []olsv1alpha1.RAGSpec{
{
IndexPath: "/rag/vector_db/ocp_product_docs/4.19",
IndexID: "ocp-product-docs-4_19",
Image: "rag-ocp-product-docs:4.19",
IndexPath: "/rag/vector_db/internal_runbooks/1.0",
IndexID: "internal-runbooks-1_0",
Image: "rag-internal-runbooks:1.0",
},
}
deployment, err := GenerateOLSDeployment(testReconcilerInstance, cr)
Expand Down
14 changes: 7 additions & 7 deletions internal/controller/appserver/reconciler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,9 +935,9 @@ var _ = Describe("App server reconciliator", Ordered, func() {
By("Reconcile with RAG defined")
cr.Spec.OLSConfig.RAG = []olsv1alpha1.RAGSpec{
{
IndexPath: "/rag/vector_db/ocp_product_docs/4.19",
IndexID: "ocp-product-docs-4_19",
Image: "rag-ocp-product-docs:4.19",
IndexPath: "/rag/vector_db/internal_runbooks/1.0",
IndexID: "internal-runbooks-1_0",
Image: "rag-internal-runbooks:1.0",
},
{
IndexPath: "/rag/vector_db/ansible_docs/2.18",
Expand Down Expand Up @@ -989,9 +989,9 @@ var _ = Describe("App server reconciliator", Ordered, func() {
By("Reconcile with RAG defined")
cr.Spec.OLSConfig.RAG = []olsv1alpha1.RAGSpec{
{
IndexPath: "/rag/vector_db/ocp_product_docs/4.19",
IndexID: "ocp-product-docs-4_19",
Image: "rag-ocp-product-docs:4.19",
IndexPath: "/rag/vector_db/internal_runbooks/1.0",
IndexID: "internal-runbooks-1_0",
Image: "rag-internal-runbooks:1.0",
},
{
IndexPath: "/rag/vector_db/ansible_docs/2.18",
Expand All @@ -1007,7 +1007,7 @@ var _ = Describe("App server reconciliator", Ordered, func() {
Expect(err).NotTo(HaveOccurred())
Expect(cm.Data).To(HaveKey(utils.OLSConfigFilename))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("indexes:"))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("product_docs_index_id: ocp-product-docs-4_19"))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("product_docs_index_id: internal-runbooks-1_0"))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("product_docs_index_path: " + utils.RAGVolumeMountPath + "/rag-0"))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("product_docs_index_id: ansible-docs-2_18"))
Expect(cm.Data[utils.OLSConfigFilename]).To(ContainSubstring("product_docs_index_path: " + utils.RAGVolumeMountPath + "/rag-1"))
Expand Down