Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/app_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ jobs:
echo "There are $N threads available"
echo "N=$N" >> $GITHUB_ENV

# Detect fork PRs — secrets are unavailable for external forks, so
# codesigning and artifact upload steps must be skipped for them.
if [[ "${{ github.event_name }}" == "pull_request" && "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]]; then
echo "IS_FORK_PR=true" >> $GITHUB_ENV
else
echo "IS_FORK_PR=false" >> $GITHUB_ENV
fi

if [ "$RUNNER_OS" == "Linux" ]; then
echo "Install needed system dependencies for OPENGL (due to Qt) for Linux"
sudo apt update -qq
Expand Down Expand Up @@ -232,7 +240,7 @@ jobs:

- name: "Configure for codesigning"
id: codesigning
if: runner.os == 'macOS'
if: runner.os == 'macOS' && env.IS_FORK_PR != 'true'
run: |
set -x
cd $RUNNER_TEMP
Expand Down Expand Up @@ -605,6 +613,7 @@ jobs:
-WaitForCompletion -Force

- name: Archive binary artifacts
if: env.IS_FORK_PR != 'true'
uses: actions/upload-artifact@v4
# build/_CPack_Packages/win64/IFW/*.exe
# build/_CPack_Packages/Linux/DEB/*.deb
Expand All @@ -614,13 +623,14 @@ jobs:
path: build/${{ matrix.BINARY_PKG_PATH }}/*.${{ env.BINARY_EXT }}

- name: Archive TGZ or ZIP artifacts
if: env.IS_FORK_PR != 'true'
uses: actions/upload-artifact@v4
with:
name: OpenStudioApplication-${{ env.OS_APP_VERSION }}.${{ github.sha }}-${{ matrix.os }}.${{ env.COMPRESSED_EXT }}
path: build/${{ matrix.COMPRESSED_PKG_PATH }}/*.${{ env.COMPRESSED_EXT }}

- name: Full Test Package signing for IFW and TGZ
if: runner.os == 'macOS'
if: runner.os == 'macOS' && env.IS_FORK_PR != 'true'
working-directory: ./build
shell: bash
run: |
Expand All @@ -632,7 +642,7 @@ jobs:
echo "::endgroup::"

- name: Upload otool info as artifact
if: runner.os == 'macOS'
if: runner.os == 'macOS' && env.IS_FORK_PR != 'true'
uses: actions/upload-artifact@v4
with:
name: otool_infos_cpack_${{ matrix.os }}_${{ matrix.arch }}
Expand All @@ -656,6 +666,7 @@ jobs:
$XVFBCMD ctest -j -T test --output-on-failure --no-compress-output -C $BUILD_TYPE || true

- name: Archive test results?
if: env.IS_FORK_PR != 'true'
uses: actions/upload-artifact@v4
with:
name: OpenStudioApplication-${{ env.OS_APP_VERSION }}.${{ github.sha }}-${{ matrix.os }}-Test.xml
Expand All @@ -678,6 +689,7 @@ jobs:
$XVFBCMD Products/SpacesSurfaces_Benchmark --benchmark_out_format=csv --benchmark_out='bench_results_SpacesSurfaces.csv' || true

- name: Archive benchmark results?
if: env.IS_FORK_PR != 'true'
uses: actions/upload-artifact@v4
with:
name: OpenStudioApplication-${{ env.OS_APP_VERSION }}.${{ github.sha }}-${{ matrix.os }}-bench_results.csv
Expand Down Expand Up @@ -723,6 +735,7 @@ jobs:
test_package_macos:
name: Test Built Package on macOS
needs: build
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
runs-on: ${{ matrix.os }}
strategy:
# fail-fast: Default is true, switch to false to allow one platform to fail and still run others
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
load: true
tags: osapp-build:latest
cache-from: type=gha,scope=osapp-build
cache-to: type=gha,scope=osapp-build,mode=max
cache-to: ${{ github.event.pull_request.head.repo.full_name == github.repository && 'type=gha,scope=osapp-build,mode=max' || '' }}

- name: Configure (Conan install + CMake configure)
run: make configure
Expand Down
Loading