Remove the remaining low hanging regexes - #875
Merged
Merged
Conversation
These were missed in the previous clean up
Collaborator
Author
|
This is the remaining regex list And since its ~50, the regex cache should more than handle it, so once compiled it will live in memory, meaning only the first run for any worker will be slowed. I cant see any others that would easily be handled by string methods |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## regex_removal #875 +/- ##
=================================================
- Coverage 84.86% 84.84% -0.02%
=================================================
Files 48 48
Lines 14558 14554 -4
=================================================
- Hits 12354 12348 -6
- Misses 2204 2206 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were missed in the previous clean up