Skip to content

Optimise VariantValidator caching and document configuration - #880

Open
Peter-J-Freeman wants to merge 2 commits into
regex_removalfrom
cache_optimisation
Open

Optimise VariantValidator caching and document configuration#880
Peter-J-Freeman wants to merge 2 commits into
regex_removalfrom
cache_optimisation

Conversation

@Peter-J-Freeman

Copy link
Copy Markdown
Collaborator

No description provided.

@Peter-J-Freeman

Copy link
Copy Markdown
Collaborator Author

Clean commit to replace the pull request #877
The old request is still open as it contains the profiling info. @John-F-Wagstaff.

The code is cleaned, cache settings moved to the settings.py so they can easily be adapted and toggled on and off, including using Environment Variables

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.89%. Comparing base (650b73a) to head (534a662).
⚠️ Report is 3 commits behind head on regex_removal.

Files with missing lines Patch % Lines
VariantValidator/modules/vvMixinConverters.py 66.66% 1 Missing ⚠️
VariantValidator/modules/vvMixinInit.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           regex_removal     #880      +/-   ##
=================================================
+ Coverage          84.84%   84.89%   +0.05%     
=================================================
  Files                 48       48              
  Lines              14554    14586      +32     
=================================================
+ Hits               12348    12383      +35     
+ Misses              2206     2203       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Regression tests added. Required hgvs dup to delins conversion in
vvMixinConverters.py
vvhgvs.global_config.uta.pool_max = 25
vvhgvs.global_config.formatting.max_ref_length = 1000000

if settings.vvHGVS_HDP_CACHE:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want a default setting here, or to not set at all (and rely on the vvhgvs default) and only set to 0 when we override it to 0 explicitly, otherwise we just flipped the default from 100 to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants