LTI self-posting form fix#3032
Open
taniwallach wants to merge 1 commit into
Open
Conversation
login stage to trigger the authentication stage on the LMS.
The parameter was is not part of the LTI standard, and is used by Moodle
to prevent the authentication stage from entering a self-reposting loop,
as a self-reposting mechanism is used to pull in the Moodle session
cookie which is no longer provided by browsers when SameSite=Lax is set
on the LMS side and the sites are considered cross-site.
Having this unneeded parameter set breaks the Moodle to WeBWorK
login/launch and content selection mechanism after Moodle changed
to defaulting to SameSite=Lax.
Additional details are in:
openwebwork#2982
taniwallach
changed the title
drgrice1
approved these changes
Jun 26, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
As far as I can tell this parameter is only used by Moodle, and so this should not affect any other LMSs. So if it is causing problems for Moodle, is should be removed.
Member
|
Also, I have tested this with both Moodle and Canvas, and everything seems to be working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the repost parameter form the LTI self-posting form used after the login stage to trigger the authentication stage on the LMS.
The parameter was is not part of the LTI standard, and is used by Moodle to prevent the authentication stage from entering a self-reposting loop, as a self-reposting mechanism is used to pull in the Moodle session cookie which is no longer provided by browsers when SameSite=Lax is set on the LMS side and the sites are considered cross-site.
Having this unneeded parameter set breaks the Moodle to WeBWorK login/launch and content selection mechanism after Moodle changed to defaulting to SameSite=Lax.
Fix for #2982