Skip to content

improve: fix misleading useSecondaryToPrimaryIndex method name #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csviri merged 1 commit into from
Aug 17, 2026
+3 −3
Merged

improve: fix misleading useSecondaryToPrimaryIndex method name #3562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ava/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public InformerEventSource(
configuration);
// If there is a primary to secondary mapper there is no need for primary to secondary index.
primaryToSecondaryMapper = configuration.getPrimaryToSecondaryMapper();
if (useSecondaryToPrimaryIndex()) {
if (usePrimaryToSecondaryIndex()) {
primaryToSecondaryIndex =
// The index uses the secondary to primary mapper (always present) to build the index
new DefaultPrimaryToSecondaryIndex<>(configuration.getSecondaryToPrimaryMapper());
Expand Down Expand Up @@ -236,7 +236,7 @@ protected void propagateEvent(R resource, R oldResource, Set<ResourceID> primary
@Override
public Set<R> getSecondaryResources(P primary) {
Set<ResourceID> secondaryIDs;
if (useSecondaryToPrimaryIndex()) {
if (usePrimaryToSecondaryIndex()) {
var primaryResourceID = ResourceID.fromResource(primary);
secondaryIDs = primaryToSecondaryIndex.getSecondaryResources(primaryResourceID);
log.debug(
Expand Down Expand Up @@ -281,7 +281,7 @@ private Set<ResourceID> handleRecentCreateOrUpdate(R newResource, R previousVers
return relatedPrimaryIds;
}

private boolean useSecondaryToPrimaryIndex() {
private boolean usePrimaryToSecondaryIndex() {
return this.primaryToSecondaryMapper == null;
}

Expand Down
Loading