Skip to content

🐛 OCPBUGS-92037: increase catalog HTTP client timeout from 10s to 5m#2787

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:increase-catalog-client-timeout
Jun 26, 2026
Merged

🐛 OCPBUGS-92037: increase catalog HTTP client timeout from 10s to 5m#2787
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
joelanford:increase-catalog-client-timeout

Conversation

@joelanford

@joelanford joelanford commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

The 10-second HTTP client timeout was too aggressive for large catalog responses,
causing timeouts when fetching catalogs. Increase it to 5 minutes.

See https://redhat.atlassian.net/browse/OCPBUGS-92037 for details of the bug.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford
🐛 OCPBUGS-92037: increase catalog HTTP client timeout from 10s to 5m
16783cd 
The 10-second timeout was too aggressive for large catalog responses.
Increase it to 5 minutes to avoid timeouts when fetching catalogs.

See https://redhat.atlassian.net/browse/OCPBUGS-92037 for details of the bug.
Copilot AI review requested due to automatic review settings June 26, 2026 14:18
@openshift-ci openshift-ci Bot requested review from grokspawn and oceanc80 June 26, 2026 14:18
@netlify

netlify Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 16783cd
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a3e8a28d7698a0008a02ac7
😎 Deploy Preview https://deploy-preview-2787--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort

tmshort commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
Copilot AI reviewed Jun 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses catalog fetch timeouts in operator-controller by increasing the HTTP client timeout used for catalogd requests, preventing failures when downloading large catalog responses.

Changes:

  • Increased the catalog metadata HTTP client timeout from 10 seconds to 5 minutes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (00db91d) to head (16783cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2787      +/-   ##
==========================================
- Coverage   70.44%   70.42%   -0.02%     
==========================================
  Files         143      143              
  Lines       10617    10617              
==========================================
- Hits         7479     7477       -2     
- Misses       2578     2579       +1     
- Partials      560      561       +1
Flag Coverage Δ
e2e 35.12% <100.00%> (-0.05%) ⬇️
experimental-e2e 52.54% <100.00%> (-0.05%) ⬇️
unit 59.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort

tmshort commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2026
rashmigottipati
rashmigottipati approved these changes Jun 26, 2026
View reviewed changes

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 0227f92 into operator-framework:main Jun 26, 2026
26 checks passed
@joelanford joelanford deleted the increase-catalog-client-timeout branch June 26, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rashmigottipati rashmigottipati rashmigottipati approved these changes
@grokspawn grokspawn Awaiting requested review from grokspawn
@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@rashmigottipati rashmigottipati

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelanford @tmshort @rashmigottipati