Focus document launches in Atelier#271
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7a9ac63e-6ef2-419e-b76e-a7199973864e) |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
flashtype-website | bc17856 | Commit Preview URL Branch Preview URL |
Jul 14 2026, 09:00 PM |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ced341ab-f7bd-4ce5-9e1b-f3f10eb93741) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d1fa3d294
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: resolvedPath, | ||
| openFilePaths: uniqueWorkspaceRelativeFilePaths(openFilePaths), | ||
| name: path.basename(resolvedPath) || resolvedPath, | ||
| ...(initialPanelMode ? { initialPanelMode } : {}), |
There was a problem hiding this comment.
For saved transient file workspaces, resolveWorkspaceSessionEntry still calls createEphemeralWorkspace(workspacePath, pendingOpenFilePaths) without the new mode argument, so a relaunch of a standalone/grouped file session with non-empty openFilePaths reopens with the normal left/right panels instead of the focused document layout used for the original file launch. Please propagate "document" when restoring session entries that have pending open files.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b79ccf4e-535f-41ba-879a-90d1800cdb96) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6cb564a5-8f33-4d8b-bbf0-b0a47f4ddd65) |
1 participant
Summary
Why
PR #269 left the document-focused panel behavior uncommitted. Direct file launches should prioritize the document, while folder launches should expose the full workspace. Advancing Atelier also moved shell state out of the shared Lix key, so FlashType needs to subscribe to the host session store to preserve transient documents across relaunches.
Impact
Users opening a file from Finder or grouped file arguments land directly in the document with a distraction-free layout. Folder launches retain visible Files and agent panels, and transient workspaces continue restoring their active document.
Dependency
defaultOpenPanelsconfiguration remains collapsedValidation
pnpm exec vitest run electron/workspace.test.ts src/lib/atelier-document-state.test.ts src/lib/atelier-workspace-bridge.test.ts— 49 passedpnpm run typecheckpnpm run buildNote
Medium Risk
Changes workspace launch layout, session persistence path, and agent-turn review key layout; regressions could affect Finder opens, relaunch restore, or pending review badges, though coverage is broad in unit and e2e tests.
Overview
Adds document-focused launch mode: direct file and transient workspace targets get
initialPanelMode: "document", which starts Atelier with both side panels collapsed; normal folder workspaces still open left and right by default.Wires Atelier to a host memory session store (
createMemorySessionStateStore) and updates the workspace bridge to persist open documents from that snapshot (subscribe + optional snapshot reads) instead of only watching the legacyatelier_ui_stateLix key. Document session helpers accept an injected UI state so relaunch/session checks stay accurate when the host owns shell state.Agent turn review ranges move from one aggregated key to per-range keys under a prefix; readers merge values via
agentTurnCommitRangesFromValues. The Files extension ignores stalewatched:opens when a newer open request wins during slow imports.Electron agent path probing runs a short script from env (avoids shells that reject long pasted commands) and finishes on marker or a brief post-exit drain. E2E gains shared workspace-session open-file assertions, dev
__flashtypeE2Esession state, multi-change review helpers, and collapsed-panel expectations for standalone launches.Reviewed by Cursor Bugbot for commit bc17856. Bugbot is set up for automated code reviews on this repo. Configure here.