[codex] test cache behavior for batched mutations#282
Open
Saiaaax wants to merge 1 commit into
Open
Conversation
Author
|
/claim #71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beforeQueryCachedoes not read cached data for aSELECT; DELETEbatch.afterQueryCachedoes not write results for the same batch, including the optional-params path.Why
node-sql-parserreturns an AST array for multi-statement SQL.hasModifyingStatementrecursively detects mutations in that array, but the behavior had no regression coverage. If it regressed, a batch containing a write could incorrectly interact with the query cache.Validation
node node_modules/vitest/vitest.mjs --run src/cache/index.test.ts— 16 tests passed.node node_modules/prettier/bin/prettier.cjs --check src/cache/index.test.ts— passed.main. Cache branch coverage increased from 81.39% to 86.04%; global branch coverage increased from 47.68% to 47.99%.git diff --check— passed.AI-assisted with Codex; the diff and test behavior were reviewed locally.
/claim #71