chore(deps): Bump js-yaml from 4.2.0 to 5.2.0#1554
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.2.0 to 5.2.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.2.0...5.2.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.2.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
DeepDiver1975
left a comment
There was a problem hiding this comment.
Dependabot bump of js-yaml 4.2.0 → 5.2.0 — this crosses a major version (v4→v5), so I reviewed the API surface carefully. Diff is manifest/lockfile only (package.json + package-lock.json); no source changes.
js-yaml major bumps have historically been risky here because the docs build can parse remote YAML files (ext-antora/load-global-site-attributes.js fetches an attribute file over http/https and parses it). I checked that file: the only API it uses is yaml.load(data). That is the modern, stable entry point — it does not use safeLoad/safeDump (removed back in v4, not v5) and does not rely on any API that changed in the v4→v5 transition. The only v5 change visible in the lockfile is the bin entry (bin/js-yaml.js → bin/js-yaml.mjs), which is the CLI binary and is not invoked by the build.
Decisive signal: the "Build documentation" CI job is green on the upgraded lockfile — that job is the real integration test of the YAML-parsing path, and it passes. No breaking API impact for this repo.
LGTM — approving and merging.
🤖 Generated with Claude Code
DeepDiver1975
left a comment
There was a problem hiding this comment.
js-yaml 4.2→5.2 (major). Only consumer uses yaml.load() (unchanged v4→v5; no safeLoad); Build documentation CI green. No breaking API impact. Approving.
Bumps js-yaml from 4.2.0 to 5.2.0.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
c28ed5e5.2.0 released125cd5aAddmaxAliasesoption3105455ReplacemaxMergeSeqLengthoption withmaxTotalMergeKeys(more robust)39d00d6numbers: Drop boxed numbers support, simplify .identify() checks, clarify rou...eb5cb5bfix: round-trip integers that stringify in exponential notation (#771)89024c4Update migration info, close #770f1e45cd5.1.0 released53b22beFix constructor coveragea1eaa2bFix quote style options and restore forceQuotes0532e7dAdd finalizers for immutable collection tagsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)