QA fixups - #2664
Merged
Merged
Conversation
Left over from a long-forgotten debugging session. Triggered a remake of 272.out to match.
localhost -> local: change in src/chknumval.c made one diagnostic slightly different for qa/273.
…in pmcd PMDA
Needed to change
sudo pmstore -h '$LOCALHOST_FULL' pmcd.control.debug ...
which will not work because it is run on a remote host aimed at
pmcd on the host where the QA test is being run and the access
controls bite early and break the test.
Replace this with
pmstore -h '$LOCALHOST_FULL' sample.write_me 42
which will work because the sample PMDA does not have the same
store access controls as the pmcd PMDA.
Actually setting pmcd.control.debug or not has no functional impact
on this QA test, we're just after *some* pmstore operation.
The comment in the test explains:
Based on smack-a-mole testing, it would appear that this PMDA is
only going to work in an AWS context where there is at least one
RDS endpoint.
This moves qa/1998 from failing+triaged to notrun *everywhere* in CI
and the QA Farm.
We really need the developers of the rds PMDA (Oracle) to step up to
the plate here and help us provision some QA environment that would
allow this PMDA to be tested.
Change chknumval.c to use "mmv.control.reload" instead of "pmcd.control.sighup" (in the default case) to dodge new access controls for pmStore in the pmcd PMDA. Triggered remake of qa/043.
Changed access controls for pmStore and the pmcd PMDA meant src/agenttimeout.c needed to create a pmNewContext using "local:" rather than "localhost". But this change needed to be reflected in qa/023 in the [access] clause and the filtering (connection is now via a Unix domain socket, not a TCP/IP port), which in turn trigeers remakes for 023.out.1 and 023.out.2.
May fix some transient failures in the QA Farm.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughQA tests and helper validation were updated for PMCD local transport normalization, timeout synchronization, pmlogger recovery, store access checks, RDS environment gating, and the default metric list. ChangesQA maintenance
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@qa/032`:
- Around line 27-29: Update the pmlogger restart flow in qa/032 to capture and
validate _service pmlogger restart’s status before passing its output to
_filter_pcp_start. Preserve the existing failure path through _exit 1 and ensure
filtering cannot mask a failed restart in this /bin/sh script.
In `@qa/1998`:
- Around line 40-42: Update the RDS endpoint check following the count
assignment to invoke _notrun with || when the test condition is true. Preserve
the existing “no RDS endpoints found” message and ensure the test exits through
the skip helper instead of treating _notrun as an argument to [.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 86bd123a-3494-4a26-bab3-9cc1ad081294
⛔ Files ignored due to path filters (3)
qa/043.outis excluded by!**/*.outqa/272.outis excluded by!**/*.outqa/273.outis excluded by!**/*.out
📒 Files selected for processing (9)
qa/023qa/023.out.1qa/023.out.2qa/032qa/069qa/1998qa/272qa/src/chknumval.cqa/triaged
💤 Files with no reviewable changes (2)
- qa/272
- qa/triaged
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@qa/1998`:
- Line 42: Reverse the preflight logic in the RDS endpoint check: update the
condition around count so empty or zero count invokes _notrun, while a positive
endpoint count allows the test to continue. Replace the current OR-based guard
with the appropriate AND-based behavior without changing the surrounding test
flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: a910d83e-63f4-4b50-a838-a2445a49fa6e
📒 Files selected for processing (2)
qa/032qa/1998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all.