ext/Intl: Implement a compatibility layer for ICU version-specific API difference#22446
Open
LamentXU123 wants to merge 3 commits into
Open
ext/Intl: Implement a compatibility layer for ICU version-specific API difference#22446LamentXU123 wants to merge 3 commits into
LamentXU123 wants to merge 3 commits into
Conversation
Member
|
I ll have a look later this week, not urgent by any mean. I understand well what it tried to solve though. |
Girgias
reviewed
Jun 25, 2026
Member
|
I had a quick glance, the unconditional forward typedefs might collide with ICU's. |
Member
Author
|
Indeed. Let's directly include them I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is quite annoying to deal with ICU version guards here and there throughout the whole extension. However, the guards are on the other hand important for the extension to work as we must check for ICU compatibility for some of our features. But that doesn't mean we need to write all these shitty
#ifstuff everywhere.I therefore wrote this PR to implement several internal APIs to check for compatibility. This very much enhance readability and reduce the possibility of making mistakes in the future when we are adding guards to new stuffs.
@devnexen please take a look if you have time, very much appreciated!!