Fix GH-22441: reflection misses dynamic prop shadowing private parent#22451
Open
iliaal wants to merge 1 commit into
Open
Fix GH-22441: reflection misses dynamic prop shadowing private parent#22451iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
ReflectionClass::hasProperty() and getProperty() look the name up in the class's properties_info table and, on a match, return before checking the object's dynamic properties. A private property declared on a parent class lives in that table but isn't visible to the child, so a dynamic property of the same name went unreported. Fold the accessibility check into the lookup so an inaccessible private-parent match falls through to the existing dynamic-property check, matching property_exists(). Fixes phpGH-22441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22441. ReflectionClass::hasProperty() and getProperty() returned a match from properties_info without first checking the object's dynamic properties. A private property on a parent class sits in that table but is invisible to the child, so a dynamic property shadowing it was reported missing, even though property_exists() and getProperties() report it. The accessibility test now folds into the lookup, so an inaccessible private-parent match falls through to the dynamic-property check.