Implement ClassAttributeRequiresPhpVersionRule#305
Merged
Conversation
staabm
force-pushed
the
refac2
branch
2 times, most recently
from
f450372 to
e48811f
Compare
staabm
commented
Jun 21, 2026
Comment on lines
+19
to
+20
| PHPStan\Rules\PHPUnit\ClassAttributeRequiresPhpVersionRule: | ||
| phpstan.rules.rule: %featureToggles.bleedingEdge% |
Contributor
Author
There was a problem hiding this comment.
technically its a new rule, but in the end we just add wiring for a pre-existing service (and its bleeding edge only).
therefore I feel confident merging, without a review from ondrej
staabm
requested review from
VincentLanglet
and removed request for
VincentLanglet
VincentLanglet
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #304