refactor(agents): enforce senior engineering principles across all agents#8
Merged
Merged
Conversation
…ents - Add _shared/engineering-principles.md: simple first / no overengineering, business-first thinking, challenge fit/risk/worth, senior-level code, no garbage code, no valueless comments - Add Engineering Principles (NON-NEGOTIABLE) block to all 16 agents, tailored per role (reviewer flags overengineering as defect, architect right-sizes, refactor never adds speculative patterns) - Developer agents: replace 'follow architecture docs exactly' with match-the-project-first (read-project-first.md), consistent with the earlier skills refactor - nodejs-backend-dev: DDD layer rules apply only when the project uses DDD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets/architecture/_shared/engineering-principles.md— single source of truth for the senior bar every agent codes to:code-reviewertreats overengineering and garbage code as defects; reviews against the pattern the codebase actually usesclean-architectmust right-size recommendations (no 4-layer Clean Architecture for simple CRUD)refactorapplies design patterns only to remove real existing complexity, never speculativelyperf-optimizer,security-audit,test-writer, etc. get role-specific challenge/worth-it bulletsread-project-first.md), consistent with the earlier skills refactor (92e6d0b)nodejs-backend-dev: DDD layer rules apply only when the project actually uses (or is migrating to) DDDCLAUDE.mdNotes
architecture/folder, so the new_sharedfile is picked up with no installer change;--project(copy) installs need a re-run ofmoicle install --project.