fix(public): make slug-collision precedence fixture self-contained

[PierreBrisorgueil]

Summary

• What changed: In the "slug-collision precedence" describe block (modules/public/tests/public.docs.integration.tests.js), the fixture's config.files.guides input no longer extends the real on-disk guide list (...originalGuides spread removed). It now uses an explicit list: the two known framework guide paths (modules/home/doc/guides/00-welcome.md, modules/home/doc/guides/01-quickstart.md) plus the fixture's own two synthetic guide paths.
• Why: The old fixture built its input by spreading originalGuides — the real, on-disk config.files.guides — which implicitly assumed at most one real guide per slug (the framework's own modules/home/). A downstream consumer that ships a second real guide at the same slug from its own module lands at the same precedence tier as the fixture and silently wins the same-tier tiebreak in resolveGuideEntries, defeating this test deterministically in that consumer's CI — even though production precedence behavior is correct. Removing the spread makes the block fully control its own input, independent of any downstream repo's real on-disk guide state.
• Related issues: Closes fix(public): slug-collision precedence test fixture collides with a second real application-tier guide module #4012

Scope

• Module(s) impacted: public (tests only)
• Cross-module impact: none
• Risk level: low

Validation

• npm run lint
• npm test
• Manual checks done (if applicable)

Guardrails check

• No secrets or credentials introduced (.env*, secrets/**, keys, tokens)
• No risky rename/move of core stack paths
• Changes remain merge-friendly for downstream projects
• Tests added or updated when behavior changed

Notes for reviewers

• Security considerations: none — test-file-only change, no source files touched, no assertions changed.
• Mergeability considerations: this is the fix motivated by the fixture-collision scenario described in fix(public): slug-collision precedence test fixture collides with a second real application-tier guide module #4012; it makes the stack's own test suite independent of a downstream consumer's real on-disk guide content.
• Follow-up tasks (optional): none

Summary by CodeRabbit

• Tests
  • Improved slug-collision test coverage by explicitly including framework and fixture guides.
  • Added documentation clarifying expected precedence when guides share the same slug.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ee1474cc-3eb4-4300-8ac4-5c7b93bc6723

📥 Commits

Reviewing files that changed from the base of the PR and between adbc2b8 and 5be2732.

📒 Files selected for processing (1)

• modules/public/tests/public.docs.integration.tests.js

---

Walkthrough

The integration test now declares the two framework guide paths explicitly before adding fixture guides. Comments document how spreading the original guide configuration could hide same-slug framework guides when consumers provide duplicate guide slugs.

Changes

Guide fixture configuration

Layer / File(s)	Summary
Explicit framework guide setup modules/public/tests/public.docs.integration.tests.js	The beforeAll setup declares the framework guide paths separately and combines them with fixture guides. Comments explain the slug-collision behavior addressed by the test setup.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related issues

• pierreb-devkit/Node#4012 — The test fixture change directly addresses the documented slug-collision precedence scenario.
• pierreb-devkit/Node#3979 — The setup explicitly includes framework and consumer guides with matching slugs.

Possibly related PRs

• pierreb-devkit/Node#4011 — This PR updates the same collision-precedence integration-test fixtures.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/4012-precedence-fixture-self-contained

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.54%. Comparing base (adbc2b8) to head (5be2732).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4014   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         170      170           
  Lines        5759     5759           
  Branches     1847     1847           
=======================================
  Hits         5387     5387           
  Misses        302      302           
  Partials       70       70           

Flag	Coverage Δ
integration	61.83% <ø> (ø)
unit	76.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbc2b8...5be2732. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.