Skip to content

fix: handle missing gh executable - #177

Merged
ecarreras merged 4 commits into
pilipilisbot:mainfrom
gisce:fix/issue-25-gh-not-found
Aug 4, 2026
Merged

fix: handle missing gh executable#177
ecarreras merged 4 commits into
pilipilisbot:mainfrom
gisce:fix/issue-25-gh-not-found

Conversation

@giscebot

@giscebot giscebot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Fixes gisce#25

Summary

  • convert a missing configured gh executable into a CompletedProcess-style failure with exit code 127
  • keep GitHub follow-up paths from crashing the worker on FileNotFoundError
  • add regression coverage for live mode

Tests

  • .venv/bin/pytest -q tests/test_modes_cli.py (10 passed)

Moved from gisce#26 at the request of @ecarreras.

giscebot added 4 commits July 16, 2026 22:32
…error

fix: tolerate runtime errors in release check
* fix: harden sqlite queue path handling

* fix: initialize sqlite after state directory recovery

@pilipilisbot pilipilisbot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I reviewed the linked Sentry issue, the migrated PR context, and the full upstream diff across dispatch, monitor, queue, and tests. The GitHubClient run wrapper preserves the CompletedProcess-style contract and turns a missing configured gh executable into return code 127, so reaction, comment, and follow-up paths can fail closed instead of crashing the worker.

The carried monitor and queue resiliency commits are also consistent with repository operations: release lookup failures remain non-fatal, user-home DB paths are expanded, and missing SQLite parent directories are recreated before reconnecting.

Verification:

  • Focused local tests: .venv/bin/pytest -q tests/test_modes_cli.py tests/test_monitor.py tests/test_queue.py -> 41 passed
  • Full local suite: .venv/bin/pytest -q -> 159 passed, 1 Starlette/httpx deprecation warning
  • GitHub checks: dashboard, pytest 3.11, and pytest 3.12 are passing

@ecarreras
ecarreras merged commit b0bdf23 into pilipilisbot:main Aug 4, 2026
3 checks passed
@pilipilisbot

Copy link
Copy Markdown
Owner

Merge event processed: PR #177 is already merged as b0bdf23, carrying the missing-gh fix from ecc87a0. I rechecked the linked Sentry issue context and reran the focused regression tests locally: .venv/bin/pytest -q tests/test_modes_cli.py tests/test_monitor.py tests/test_queue.py -> 41 passed. No follow-up code changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileNotFoundError: [Errno 2] No such file or directory: 'gh'

3 participants