fix(install): support PILOT_TRANSPORT env var for compat mode (PILOT-222)#349
Open
matthew-pilot wants to merge 1 commit into
Open
fix(install): support PILOT_TRANSPORT env var for compat mode (PILOT-222)#349matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
The daemon already auto-probes UDP reachability and falls back to compat (WSS/443) transport when UDP is blocked (PR #314, commit f0c422f). This change adds PILOT_TRANSPORT env var support to install.sh for users who want to explicitly force a transport mode on systems where UDP may be unavailable. Changes: - Document PILOT_TRANSPORT=compat in Usage section + new ENVIRONMENT VARIABLES header block - Pass -transport flag to systemd unit when PILOT_TRANSPORT is set - Pass -transport to LaunchAgent plist when PILOT_TRANSPORT is set Closes PILOT-222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The daemon already auto-probes UDP reachability and falls back to compat (WSS/443) transport when UDP is blocked (PR #314, commit f0c422f). This change adds
PILOT_TRANSPORTenv var support toinstall.shfor users who want to explicitly force a transport mode on systems where UDP may be unavailable.What was failing
install.shdid not pass-transportto the systemd unit or LaunchAgent plist, and had no documentation for thePILOT_TRANSPORTenv var. Users on UDP-blocked hosts had no way to force compat mode through the installer — they had to manually edit the service file or the plist after install.Fix
PILOT_TRANSPORT=compatto the Usage examples and a new ENVIRONMENT VARIABLES header block-transport $PILOT_TRANSPORTin ExecStart when the env var is set (following the same pattern asPILOT_HOSTNAME/PILOT_PUBLIC)-transport+ value strings when the env var is set (same EXTRA_ARGS pattern)Verification
bash -n install.sh— syntax OKdash -n install.sh— syntax OK (POSIX sh compat)Closes https://vulturelabs.atlassian.net/browse/PILOT-222