spfresh: rename search beam request field#420
Merged
Lloyd-Pottiger merged 1 commit intoJul 7, 2026
Merged
Conversation
Rename SPFreshSearchRequest field 9 from base_beam_size to search_beam_size so TiPB matches TiDB SQL and TiKV request semantics. The wire number stays unchanged. Regenerate Go bindings and refresh proto.lock after the schema rename.
|
|
Lloyd-Pottiger
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename SPFreshSearchRequest field 9 from base_beam_size to search_beam_size so TiPB matches TiDB SQL and TiKV request semantics. The wire number stays unchanged.
Regenerate Go bindings and refresh proto.lock after the schema rename.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn: