Skip to content

Clear VCS presentation state on finish#3764

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/mobile-git-action-stuck
Jul 7, 2026
Merged

Clear VCS presentation state on finish#3764
juliusmarminge merged 1 commit into
mainfrom
t3code/mobile-git-action-stuck

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Clear client-side VCS action presentation state when an action finishes, instead of carrying forward stale labels and output.
  • Add coverage for the finished-state reset behavior in packages/client-runtime.
  • Reduce the mobile widget asset pipeline to a single splash asset and tighten widget activity display to the top 3 rows.
  • Update mobile plugin wiring so the widget asset catalog is attached after expo-widgets creates the target.

Testing

  • Added/updated unit tests in packages/client-runtime/src/state/vcsAction.test.ts.
  • Updated relay tests for the new 3-row agent activity cap.
  • Not run: vp check.
  • Not run: vp run typecheck.
  • Not run: vp test.
  • Not run: vp run lint:mobile.

Note

Low Risk
Localized client-side state reducer change with new unit coverage; no auth, network, or persistence impact.

Overview
VCS action UI state no longer keeps phase labels, hook output, or other in-progress fields after a stacked Git action completes successfully.

On action_finished, applyVcsActionProgressEvent now resets from EMPTY_VCS_ACTION_STATE (like action_failed) and only keeps actionId, action, and operation, instead of spreading the prior current state with isRunning: false. A unit test asserts labels and lastOutputLine are cleared while the completed action identity remains.

Reviewed by Cursor Bugbot for commit 01f6d29. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Clear transient presentation state when a VCS action finishes

In the applyVcsActionProgressEvent reducer, the action_finished case now spreads EMPTY_VCS_ACTION_STATE instead of current state, preserving only actionId, action, and operation. This clears transient fields like currentLabel, currentPhaseLabel, hookName, and lastOutputLine that previously persisted after an action completed.

Macroscope summarized 01f6d29.

- Reset running UI state when a VCS action completes
- Add regression coverage for finished action cleanup
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 483b9dbc-48ea-4dfe-9c2c-cd931581eb3c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/mobile-git-action-stuck

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 7, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Simple bug fix that properly clears VCS presentation state (labels, output) when an action finishes, using the existing EMPTY_VCS_ACTION_STATE constant instead of a partial reset. Self-contained client-side state change with accompanying test.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 4414f92 into main Jul 7, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the t3code/mobile-git-action-stuck branch July 7, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant