Fix: python code gen path to copy - #62
Open
pingelit wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the in-source Python code generation copy step so the generated Python file is copied into the correct destination directory (rather than treating the destination as a file path).
Changes:
- Compute the parent directory of the intended in-source Python output path.
- Update the
file(COPY ...)destination to that parent directory to avoid invalid file-path destinations.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
316
to
+325
| if (GEN_DATA_OUTPUT_PYTHON) | ||
| if (NOT EXISTS ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON}) | ||
| file (MAKE_DIRECTORY ${GEN_DATA_IN_SOURCE_PATH}) | ||
| endif () | ||
|
|
||
| # get the parent directory of the output python file | ||
| get_filename_component (GEN_DATA_OUTPUT_PYTHON_PARENT_DIR ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON} DIRECTORY) | ||
|
|
||
| file (COPY ${GEN_DATA_OUTPUT_BASE_DIR}/${GEN_DATA_OUTPUT_PYTHON} | ||
| DESTINATION ${GEN_DATA_IN_SOURCE_PATH}/${GEN_DATA_OUTPUT_PYTHON} | ||
| DESTINATION ${GEN_DATA_OUTPUT_PYTHON_PARENT_DIR} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
===========================================
+ Coverage 78.28% 99.33% +21.04%
===========================================
Files 11 4 -7
Lines 935 150 -785
Branches 203 0 -203
===========================================
- Hits 732 149 -583
+ Misses 191 1 -190
+ Partials 12 0 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title states.