Improve platform architecture detection for arm on Linux and Windows#290
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! I'll try to review this soon. |
camdecoster
requested changes
May 28, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
This is a great change! I'd like a couple of changes, but this is an improvement.
| arch_detected = "arm" if platform.processor() == "arm" else "x" | ||
| def get_google_platform_string() -> str | None: | ||
| arch_size_detected = "64" if sys.maxsize > 2 ** 32 else "32" | ||
| is_x86 = platform.processor() not in {"arm", "aarch64"} |
Contributor
There was a problem hiding this comment.
Could you please refactor your PR to use platform.machine() instead? platform.processor() on my Linux machine just returns an empty string. In that case, is_x86 would be True which would lead to the incorrect download.
| chrome_platform_detected = get_google_platform_string() | ||
| if chrome_platform_detected in supported_platform_strings: | ||
| return chrome_platform_detected | ||
| return "" |
Contributor
There was a problem hiding this comment.
Let's return None instead of an empty string to match the type annotation.
Suggested change
| return "" | |
| return None |
| def get_google_supported_platform_string() -> str | None: | ||
| arch_size_detected = "64" if sys.maxsize > 2**32 else "32" | ||
| arch_detected = "arm" if platform.processor() == "arm" else "x" | ||
| def get_google_platform_string() -> str | None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def get_google_platform_string() -> str | None: | |
| # Returns the detected platform string, including ones not in | |
| # supported_platform_strings (e.g. linux-arm64, win-arm64) so callers | |
| # can surface them in error messages. | |
| def get_google_platform_string() -> str | None: |
camdecoster
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows better detection of arm processors on Linux and Windows to prevent downloading incorrect binaries and to show a better error message.
Closes #289.