Make plotly-cloud a default install dependency - #3947
Open
T4rk1n wants to merge 2 commits into
Open
Conversation
plotly-cloud is now installed by default with dash instead of only via the optional dash[cloud] extra. The extra is kept for backward compatibility. Update the plotly CLI ImportError hint to no longer point at dash[cloud]. Closes #3513
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
plotly-clouda default install dependency of Dash instead of only being available through the optionaldash[cloud]extra.plotly-cloud(imported asplotly_cloud) powers theplotlyconsole entry point and Dash's cloud integration indash/dash.py, so shipping it by default means those features work out of the box.Changes
plotly-cloudtorequirements/install.txt(unpinned, matching the file's existing style andrequirements/cloud.txt).cloudextra (requirements/cloud.txt+setup.pyextras_require) unchanged sopip install dash[cloud]still resolves for backward compatibility. It is now redundant but non-breaking.dash/_plotly_cli.py: sinceplotly-cloudis now always installed, the staledash[cloud]suggestion is replaced withpip install plotly-cloud(or reinstalling dash). The defensive try/except is retained.Closes #3513