Allow null in renv.lock lists#803
Merged
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
joshyam-k
reviewed
Jun 26, 2026
| "Version": "1.0.0", | ||
| "Source": "Repository", | ||
| "Repository": "CRAN", | ||
| "Imports": ["R6", None], |
Contributor
There was a problem hiding this comment.
why not use Null to match the exact case that this is intended to fix?
Collaborator
Author
There was a problem hiding this comment.
If I'm following the code correctly, this is actually all a Python dict representation that will then get written to JSON at
rsconnect-python/tests/test_environment_r.py
Lines 12 to 13 in bac8f22
null and then it will get read in and yadda yadda...
Collaborator
Author
There was a problem hiding this comment.
It's tricky cause they look sooooo close ... and then they are not 🫠
joshyam-k
approved these changes
Jun 26, 2026
joshyam-k
left a comment
joshyam-k
left a comment
Contributor
There was a problem hiding this comment.
one comment otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Allow lists to have
nullin them without breaking.Resolves: #801
Type of Change
Approach
Strip
nulls out of lists in renv.lock filesAutomated Tests
Added a test.
Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.