Skip to content

Reject MLD_PREHASH_NONE in prehash APIs#1228

Open
fegge wants to merge 3 commits into
mainfrom
ptp/prehash-none-message-bypass
Open

Reject MLD_PREHASH_NONE in prehash APIs#1228
fegge wants to merge 3 commits into
mainfrom
ptp/prehash-none-message-bypass

Conversation

@fegge

@fegge fegge commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reject MLD_PREHASH_NONE in the unstable pre-hash signing and verification APIs.
  • Document that MLD_PREHASH_NONE is not supported by these HashML-DSA entry points.
  • Add functional coverage for the rejected pre-hash algorithm.

Validation

  • clang-format -i mldsa/src/sign.c mldsa/src/sign.h mldsa/mldsa_native.h test/src/test_mldsa.c: passed
  • git diff --check -- mldsa/src/sign.c mldsa/src/sign.h mldsa/mldsa_native.h test/src/test_mldsa.c: passed
  • make run_func -j4: passed
  • Not run: ./scripts/format because nixpkgs-fmt is not installed in this local environment
  • Not run: ./scripts/lint because shfmt is not installed in this local environment

Fixes #1215


This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.

fegge added 2 commits June 26, 2026 18:17
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-65, REDUCE-RAM)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 1455s 1424s +2.2%
polyvec_matrix_pointwise_montgomery_yvec 200s 187s +7%
poly_pointwise_montgomery_c 114s 117s -3%
mld_invntt_layer 108s 101s +7%
sign_verify_internal 71s 68s +4%
mld_ntt_layer 45s 42s +7%
polyvecl_chknorm 44s 41s +7%
fqmul 42s 40s +5%
mld_attempt_signature_generation 33s 33s +0%
polyveck_chknorm 32s 31s +3%
keccakf1600x4_permute_native 25s 20s +25%
mld_ntt_butterfly_block 20s 23s -13%
poly_ntt_c 19s 18s +6%
rej_uniform_c 17s 16s +6%
mld_check_pct 16s 12s +33%
poly_chknorm_c 15s 12s +25%
polyt0_unpack 12s 13s -8%
poly_uniform_eta_4x 11s 12s -8%
polyveck_decompose 11s 12s -8%
polyvec_matrix_pointwise_montgomery_row 10s 6s +67%
keccak_absorb_once_x4 9s 8s +12%
keccak_squeezeblocks_x4 9s 3s +200%
poly_invntt_tomont_c 9s 11s -18%
polyz_unpack_c 9s 7s +29%
mld_keccakf1600_permute_c 8s 6s +33%
poly_add 8s 5s +60%
polyveck_invntt_tomont 8s 6s +33%
compute_pack_t0_t1 7s 7s +0%
polyveck_reduce 7s 8s -12%
polyvecl_ntt 7s 5s +40%
rej_uniform 7s 7s +0%
sign_pk_from_sk 7s 8s -12%
intt_native_aarch64 6s 4s +50%
mld_prepare_domain_separation_prefix 6s 3s +100%
mld_sample_s1_s2 6s 4s +50%
pointwise_acc_native_aarch64 6s 6s +0%
pointwise_acc_native_x86_64 6s 5s +20%
polyveck_unpack_eta 6s 3s +100%
rej_eta_native 6s 2s +200%
rej_uniform_native_aarch64 6s 5s +20%
keccakf1600x4_xor_bytes 5s 3s +67%
montgomery_reduce 5s 3s +67%
poly_caddq 5s 4s +25%
poly_chknorm_native 5s 2s +150%
poly_decompose_c 5s 6s -17%
poly_use_hint_native 5s 1s +400%
polyveck_caddq 5s 5s +0%
polyvecl_pointwise_acc_montgomery_c 5s 3s +67%
polyz_unpack_native 5s 2s +150%
shake256_squeeze 5s 2s +150%
sign_keypair_internal 5s 3s +67%
intt_native_x86_64 4s 2s +100%
keccakf1600x4_xor_bytes_native 4s 3s +33%
mld_compute_pack_z 4s 5s -20%
mld_ct_cmask_nonzero_u8 4s 2s +100%
mld_ct_get_optblocker_u32 4s 3s +33%
mld_keccakf1600_extract_bytes 4s 2s +100%
mld_polymat_expand_entry 4s 2s +100%
mld_value_barrier_u32 4s 2s +100%
ntt_native_aarch64 4s 4s +0%
ntt_native_x86_64 4s 4s +0%
pack_sig_h 4s 4s +0%
pack_sig_z 4s 5s -20%
poly_caddq_c 4s 4s +0%
poly_chknorm_native_x86_64 4s 3s +33%
poly_decompose_native 4s 2s +100%
poly_ntt_native 4s 4s +0%
poly_pointwise_montgomery 4s 1s +300%
poly_power2round 4s 3s +33%
poly_reduce 4s 6s -33%
poly_uniform_4x 4s 4s +0%
poly_uniform_eta 4s 2s +100%
poly_use_hint_native_aarch64 4s 3s +33%
polyt0_pack 4s 7s -43%
polyt1_unpack 4s 2s +100%
polyvecl_unpack_eta 4s 3s +33%
polyz_unpack_19_native_aarch64 4s 3s +33%
polyz_unpack_native_x86_64 4s 3s +33%
rej_uniform_native 4s 4s +0%
shake256_absorb 4s 2s +100%
sign_signature_pre_hash_shake256 4s 6s -33%
sign_verify_pre_hash_internal 4s 4s +0%
unpack_sk_s2hat 4s 4s +0%
caddq 3s 1s +200%
keccak_f1600_x4_native_aarch64_v84a 3s 4s -25%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 6s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 4s -25%
keccak_init 3s 4s -25%
keccak_squeeze 3s 7s -57%
keccakf1600_extract_bytes (big endian) 3s 2s +50%
keccakf1600_permute 3s 2s +50%
keccakf1600_xor_bytes (big endian) 3s 2s +50%
keccakf1600x4_extract_bytes_native 3s 4s -25%
mld_ct_cmask_neg_i32 3s 2s +50%
mld_ct_get_optblocker_u8 3s 4s -25%
mld_ct_memcmp 3s 3s +0%
mld_h 3s 3s +0%
mld_keccakf1600x4_xor_bytes_c 3s 3s +0%
mld_sample_s1_s2_serial 3s 3s +0%
mld_value_barrier_i64 3s 2s +50%
pack_sk_rho_key_tr_s2 3s 1s +200%
pointwise_native_x86_64 3s 2s +50%
poly_caddq_native_aarch64 3s 3s +0%
poly_caddq_native_x86_64 3s 2s +50%
poly_challenge 3s 5s -40%
poly_decompose 3s 3s +0%
poly_invntt_tomont_native 3s 3s +0%
poly_permute_bitrev_to_custom_optional 3s 3s +0%
poly_pointwise_montgomery_native 3s 2s +50%
poly_uniform 3s 2s +50%
poly_uniform_gamma1 3s 7s -57%
poly_uniform_gamma1_4x 3s 3s +0%
poly_use_hint_c 3s 2s +50%
polyeta_pack 3s 2s +50%
polyt1_pack 3s 3s +0%
polyvec_matrix_expand_serial 3s 4s -25%
polyveck_pack_w1 3s 2s +50%
polyvecl_pointwise_acc_montgomery_native 3s 3s +0%
polyvecl_uniform_gamma1 3s 2s +50%
polyvecl_uniform_gamma1_serial 3s 1s +200%
polyw1_pack_32 3s 5s -40%
polyw1_pack_88 3s 1s +200%
polyz_unpack 3s 3s +0%
rej_uniform_eta_native_aarch64 3s 3s +0%
shake128_absorb 3s 2s +50%
shake128_release 3s 3s +0%
shake128x4_squeezeblocks 3s 3s +0%
shake256_init 3s 3s +0%
shake256x4_absorb_once 3s 4s -25%
sign_keypair 3s 4s -25%
sign_signature 3s 4s -25%
sign_signature_extmu 3s 4s -25%
sign_signature_internal 3s 6s -50%
sign_signature_pre_hash_internal 3s 4s -25%
sign_verify_pre_hash_shake256 3s 5s -40%
sk_s1hat_get_poly 3s 2s +50%
sk_s2hat_get_poly 3s 2s +50%
sk_t0hat_get_poly 3s 3s +0%
unpack_sk 3s 5s -40%
yvec_init 3s 4s -25%
decompose 2s 6s -67%
fqscale 2s 1s +100%
keccak_absorb 2s 4s -50%
keccak_f1600_x1_native_aarch64_v84a 2s 3s -33%
keccak_f1600_x4_native_avx2 2s 3s -33%
keccak_finalize 2s 2s +0%
keccakf1600_permute_native 2s 3s -33%
keccakf1600x4_extract_bytes 2s 1s +100%
keccakf1600x4_permute 2s 1s +100%
make_hint 2s 3s -33%
mld_ct_abs_i32 2s 2s +0%
mld_ct_cmask_nonzero_u32 2s 3s -33%
mld_ct_get_optblocker_i64 2s 3s -33%
mld_ct_sel_int32 2s 1s +100%
mld_keccakf1600x4_extract_bytes_c 2s 5s -60%
nttunpack_native_x86_64 2s 4s -50%
pack_sk_s1 2s 3s -33%
pointwise_native_aarch64 2s 4s -50%
poly_caddq_native 2s 3s -33%
poly_chknorm 2s 4s -50%
poly_chknorm_native_aarch64 2s 3s -33%
poly_decompose_88_native_aarch64 2s 3s -33%
poly_invntt_tomont 2s 2s +0%
poly_ntt 2s 1s +100%
poly_permute_bitrev_to_custom_optional_native 2s 3s -33%
poly_sub 2s 4s -50%
poly_use_hint 2s 2s +0%
polyeta_unpack 2s 3s -33%
polyveck_pack_eta 2s 2s +0%
polyvecl_pack_eta 2s 2s +0%
polyvecl_pointwise_acc_montgomery 2s 3s -33%
polyw1_pack 2s 2s +0%
polyz_pack 2s 5s -60%
power2round 2s 3s -33%
rej_eta_c 2s 3s -33%
shake128_finalize 2s 1s +100%
shake128_init 2s 2s +0%
shake128_squeeze 2s 2s +0%
shake128x4_absorb_once 2s 2s +0%
shake256 2s 2s +0%
shake256_finalize 2s 4s -50%
shake256x4_squeezeblocks 2s 1s +100%
sig_unpack_hints 2s 2s +0%
sign_verify 2s 4s -50%
sign_verify_extmu 2s 2s +0%
sys_check_capability 2s 2s +0%
unpack_pk_t1 2s 4s -50%
unpack_sk_s1hat 2s 3s -33%
use_hint 2s 3s -33%
keccak_f1600_x1_native_aarch64 1s 2s -50%
keccakf1600_xor_bytes 1s 4s -75%
mld_value_barrier_u8 1s 3s -67%
pack_sig_c 1s 3s -67%
poly_decompose_32_native_aarch64 1s 4s -75%
poly_shiftl 1s 5s -80%
polyvec_matrix_expand 1s 3s -67%
polyveck_ntt 1s 4s -75%
polyvecl_unpack_z 1s 3s -67%
polyz_unpack_17_native_aarch64 1s 4s -75%
reduce32 1s 5s -80%
rej_eta 1s 3s -67%
shake256_release 1s 3s -67%
unpack_sk_t0hat 1s 2s -50%
yvec_get_poly 1s 2s -50%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-44, REDUCE-RAM)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 1590s 1329s +19.6%
polyvec_matrix_pointwise_montgomery_yvec 181s 151s +20%
poly_pointwise_montgomery_c 164s 117s +40%
mld_invntt_layer 133s 104s +28%
polyveck_chknorm 76s 64s +19%
sign_verify_internal 59s 51s +16%
mld_ntt_layer 50s 42s +19%
fqmul 49s 40s +23%
keccakf1600x4_permute_native 25s 24s +4%
mld_ntt_butterfly_block 24s 21s +14%
poly_ntt_c 24s 19s +26%
mld_attempt_signature_generation 22s 20s +10%
rej_uniform_c 19s 16s +19%
polyeta_unpack 18s 13s +38%
mld_check_pct 16s 12s +33%
polyvecl_chknorm 16s 14s +14%
poly_uniform_eta_4x 15s 12s +25%
polyt0_unpack 15s 12s +25%
compute_pack_t0_t1 14s 12s +17%
poly_chknorm_c 13s 12s +8%
poly_invntt_tomont_c 13s 11s +18%
keccak_absorb_once_x4 11s 9s +22%
polyz_unpack_c 11s 8s +38%
polyveck_decompose 9s 8s +12%
mld_compute_pack_z 8s 7s +14%
poly_add 8s 9s -11%
polyvec_matrix_pointwise_montgomery_row 8s 5s +60%
rej_uniform 8s 9s -11%
mld_keccakf1600_permute_c 7s 6s +17%
pointwise_acc_native_aarch64 7s 3s +133%
poly_challenge 7s 3s +133%
rej_eta_native 7s 3s +133%
sign_signature_pre_hash_shake256 7s 3s +133%
poly_caddq_native_x86_64 6s 5s +20%
poly_invntt_tomont_native 6s 3s +100%
poly_power2round 6s 3s +100%
poly_reduce 6s 5s +20%
poly_use_hint_native_aarch64 6s 2s +200%
sign_keypair_internal 6s 5s +20%
sign_pk_from_sk 6s 7s -14%
sign_signature 6s 3s +100%
sign_signature_pre_hash_internal 6s 4s +50%
sign_verify_pre_hash_internal 6s 3s +100%
fqscale 5s 2s +150%
intt_native_aarch64 5s 2s +150%
keccak_squeezeblocks_x4 5s 2s +150%
keccakf1600_xor_bytes 5s 2s +150%
mld_value_barrier_u32 5s 2s +150%
pack_sig_h 5s 4s +25%
pointwise_acc_native_x86_64 5s 4s +25%
poly_caddq 5s 4s +25%
poly_caddq_c 5s 3s +67%
poly_decompose_c 5s 5s +0%
poly_uniform 5s 4s +25%
poly_uniform_eta 5s 3s +67%
polyvecl_uniform_gamma1 5s 3s +67%
polyw1_pack_88 5s 4s +25%
rej_eta_c 5s 4s +25%
sign_signature_internal 5s 4s +25%
sys_check_capability 5s 4s +25%
unpack_sk_t0hat 5s 3s +67%
use_hint 5s 2s +150%
intt_native_x86_64 4s 4s +0%
keccak_squeeze 4s 2s +100%
mld_h 4s 4s +0%
nttunpack_native_x86_64 4s 2s +100%
pack_sk_s1 4s 3s +33%
pointwise_native_aarch64 4s 3s +33%
poly_caddq_native 4s 1s +300%
poly_chknorm 4s 3s +33%
poly_chknorm_native_aarch64 4s 2s +100%
poly_decompose_88_native_aarch64 4s 2s +100%
poly_decompose_native 4s 2s +100%
poly_ntt_native 4s 1s +300%
poly_pointwise_montgomery_native 4s 4s +0%
poly_sub 4s 2s +100%
poly_uniform_4x 4s 3s +33%
poly_use_hint_c 4s 2s +100%
polyeta_pack 4s 3s +33%
polyt0_pack 4s 8s -50%
polyt1_unpack 4s 3s +33%
polyveck_caddq 4s 3s +33%
polyveck_invntt_tomont 4s 1s +300%
polyveck_ntt 4s 2s +100%
polyveck_pack_w1 4s 2s +100%
polyveck_reduce 4s 5s -20%
polyz_unpack_19_native_aarch64 4s 2s +100%
rej_eta 4s 1s +300%
rej_uniform_native 4s 5s -20%
rej_uniform_native_aarch64 4s 3s +33%
shake128x4_absorb_once 4s 2s +100%
sign_keypair 4s 4s +0%
sign_signature_extmu 4s 5s -20%
sign_verify 4s 4s +0%
sk_t0hat_get_poly 4s 1s +300%
unpack_sk_s1hat 4s 3s +33%
caddq 3s 3s +0%
decompose 3s 2s +50%
keccak_absorb 3s 4s -25%
keccak_f1600_x4_native_aarch64_v84a 3s 1s +200%
keccak_init 3s 2s +50%
keccakf1600_extract_bytes (big endian) 3s 1s +200%
keccakf1600_permute_native 3s 2s +50%
keccakf1600x4_permute 3s 1s +200%
keccakf1600x4_xor_bytes 3s 3s +0%
make_hint 3s 2s +50%
mld_ct_abs_i32 3s 2s +50%
mld_ct_cmask_nonzero_u32 3s 3s +0%
mld_ct_cmask_nonzero_u8 3s 2s +50%
mld_ct_memcmp 3s 3s +0%
mld_keccakf1600_extract_bytes 3s 3s +0%
mld_keccakf1600x4_extract_bytes_c 3s 3s +0%
mld_keccakf1600x4_xor_bytes_c 3s 3s +0%
mld_polymat_expand_entry 3s 2s +50%
mld_prepare_domain_separation_prefix 3s 4s -25%
mld_sample_s1_s2 3s 4s -25%
mld_sample_s1_s2_serial 3s 4s -25%
ntt_native_x86_64 3s 5s -40%
pack_sig_z 3s 6s -50%
pack_sk_rho_key_tr_s2 3s 3s +0%
poly_caddq_native_aarch64 3s 1s +200%
poly_chknorm_native 3s 2s +50%
poly_chknorm_native_x86_64 3s 5s -40%
poly_decompose_32_native_aarch64 3s 2s +50%
poly_permute_bitrev_to_custom_optional_native 3s 4s -25%
poly_pointwise_montgomery 3s 3s +0%
poly_uniform_gamma1 3s 2s +50%
polyt1_pack 3s 3s +0%
polyveck_pack_eta 3s 3s +0%
polyvecl_ntt 3s 5s -40%
polyvecl_pointwise_acc_montgomery 3s 2s +50%
polyvecl_unpack_eta 3s 2s +50%
polyvecl_unpack_z 3s 2s +50%
polyw1_pack 3s 4s -25%
polyw1_pack_32 3s 2s +50%
polyz_unpack_native 3s 3s +0%
shake256 3s 4s -25%
shake256_absorb 3s 2s +50%
shake256_release 3s 2s +50%
sig_unpack_hints 3s 2s +50%
sign_verify_extmu 3s 4s -25%
sign_verify_pre_hash_shake256 3s 3s +0%
sk_s1hat_get_poly 3s 3s +0%
unpack_sk_s2hat 3s 7s -57%
yvec_get_poly 3s 3s +0%
yvec_init 3s 2s +50%
keccak_f1600_x1_native_aarch64 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 1s +100%
keccak_f1600_x4_native_avx2 2s 1s +100%
keccak_finalize 2s 2s +0%
keccakf1600_permute 2s 1s +100%
keccakf1600_xor_bytes (big endian) 2s 2s +0%
keccakf1600x4_extract_bytes_native 2s 3s -33%
keccakf1600x4_xor_bytes_native 2s 3s -33%
mld_ct_cmask_neg_i32 2s 5s -60%
mld_ct_get_optblocker_u32 2s 5s -60%
mld_ct_get_optblocker_u8 2s 2s +0%
mld_value_barrier_u8 2s 1s +100%
montgomery_reduce 2s 2s +0%
ntt_native_aarch64 2s 4s -50%
pack_sig_c 2s 1s +100%
pointwise_native_x86_64 2s 4s -50%
poly_decompose 2s 2s +0%
poly_ntt 2s 3s -33%
poly_permute_bitrev_to_custom_optional 2s 3s -33%
poly_shiftl 2s 3s -33%
poly_uniform_gamma1_4x 2s 2s +0%
poly_use_hint 2s 2s +0%
poly_use_hint_native 2s 2s +0%
polyvec_matrix_expand 2s 3s -33%
polyvec_matrix_expand_serial 2s 4s -50%
polyveck_unpack_eta 2s 3s -33%
polyvecl_pointwise_acc_montgomery_c 2s 5s -60%
polyvecl_pointwise_acc_montgomery_native 2s 2s +0%
polyvecl_uniform_gamma1_serial 2s 2s +0%
polyz_pack 2s 3s -33%
polyz_unpack 2s 2s +0%
polyz_unpack_17_native_aarch64 2s 3s -33%
polyz_unpack_native_x86_64 2s 4s -50%
power2round 2s 1s +100%
reduce32 2s 3s -33%
rej_uniform_eta_native_aarch64 2s 3s -33%
shake128_finalize 2s 2s +0%
shake128_init 2s 3s -33%
shake128x4_squeezeblocks 2s 1s +100%
shake256_finalize 2s 4s -50%
shake256_squeeze 2s 2s +0%
shake256x4_absorb_once 2s 4s -50%
shake256x4_squeezeblocks 2s 3s -33%
sk_s2hat_get_poly 2s 5s -60%
unpack_pk_t1 2s 2s +0%
unpack_sk 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a 1s 3s -67%
keccakf1600x4_extract_bytes 1s 2s -50%
mld_ct_get_optblocker_i64 1s 1s +0%
mld_ct_sel_int32 1s 3s -67%
mld_value_barrier_i64 1s 3s -67%
poly_invntt_tomont 1s 1s +0%
polyvecl_pack_eta 1s 3s -67%
shake128_absorb 1s 1s +0%
shake128_release 1s 2s -50%
shake128_squeeze 1s 1s +0%
shake256_init 1s 3s -67%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-87, REDUCE-RAM)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 1498s 1442s +3.9%
polyvec_matrix_pointwise_montgomery_yvec 201s 187s +7%
poly_pointwise_montgomery_c 129s 122s +6%
mld_invntt_layer 119s 103s +16%
sign_verify_internal 48s 43s +12%
mld_ntt_layer 45s 42s +7%
fqmul 41s 39s +5%
polyvecl_chknorm 37s 36s +3%
mld_attempt_signature_generation 34s 32s +6%
keccakf1600x4_permute_native 21s 22s -5%
mld_ntt_butterfly_block 21s 21s +0%
poly_ntt_c 20s 21s -5%
mld_check_pct 17s 15s +13%
poly_chknorm_c 14s 11s +27%
polyeta_unpack 14s 14s +0%
polyt0_unpack 14s 12s +17%
rej_uniform_c 14s 18s -22%
poly_uniform_eta_4x 13s 10s +30%
polyvec_matrix_pointwise_montgomery_row 13s 12s +8%
polyveck_decompose 13s 11s +18%
compute_pack_t0_t1 12s 13s -8%
poly_invntt_tomont_c 12s 12s +0%
pointwise_acc_native_x86_64 11s 8s +38%
mld_sample_s1_s2 9s 9s +0%
polyveck_caddq 9s 6s +50%
polyveck_chknorm 9s 11s -18%
polyvecl_ntt 9s 9s +0%
polyz_unpack_c 9s 11s -18%
keccak_absorb_once_x4 8s 9s -11%
mld_keccakf1600_permute_c 8s 6s +33%
polyveck_reduce 8s 8s +0%
rej_uniform 8s 7s +14%
mld_sample_s1_s2_serial 7s 5s +40%
poly_decompose_c 7s 5s +40%
poly_reduce 7s 6s +17%
sign_pk_from_sk 7s 7s +0%
mld_compute_pack_z 6s 4s +50%
pointwise_acc_native_aarch64 6s 8s -25%
poly_add 6s 8s -25%
poly_caddq_c 6s 3s +100%
polyveck_invntt_tomont 6s 7s -14%
polyvecl_unpack_z 6s 3s +100%
sign_verify_pre_hash_internal 6s 3s +100%
keccak_squeezeblocks_x4 5s 4s +25%
mld_h 5s 3s +67%
mld_value_barrier_i64 5s 3s +67%
ntt_native_x86_64 5s 3s +67%
pack_sk_s1 5s 4s +25%
pointwise_native_x86_64 5s 3s +67%
poly_caddq_native_x86_64 5s 2s +150%
poly_challenge 5s 5s +0%
poly_chknorm 5s 3s +67%
poly_pointwise_montgomery_native 5s 4s +25%
poly_power2round 5s 4s +25%
poly_shiftl 5s 2s +150%
poly_uniform 5s 4s +25%
poly_uniform_4x 5s 4s +25%
polyveck_ntt 5s 3s +67%
rej_uniform_native 5s 5s +0%
shake128_init 5s 2s +150%
shake256_finalize 5s 2s +150%
sign_signature_internal 5s 6s -17%
sign_signature_pre_hash_shake256 5s 5s +0%
sign_verify_pre_hash_shake256 5s 5s +0%
intt_native_aarch64 4s 3s +33%
keccak_absorb 4s 3s +33%
keccakf1600_permute_native 4s 2s +100%
mld_ct_cmask_nonzero_u32 4s 4s +0%
mld_ct_memcmp 4s 3s +33%
ntt_native_aarch64 4s 4s +0%
poly_caddq_native 4s 4s +0%
poly_chknorm_native 4s 3s +33%
poly_decompose_native 4s 5s -20%
poly_invntt_tomont 4s 1s +300%
poly_sub 4s 2s +100%
poly_use_hint 4s 2s +100%
poly_use_hint_c 4s 4s +0%
poly_use_hint_native_aarch64 4s 5s -20%
polyt1_unpack 4s 5s -20%
polyveck_unpack_eta 4s 4s +0%
polyvecl_uniform_gamma1_serial 4s 2s +100%
polyw1_pack_32 4s 3s +33%
polyz_unpack_19_native_aarch64 4s 3s +33%
rej_eta_c 4s 3s +33%
sig_unpack_hints 4s 3s +33%
sign_keypair 4s 4s +0%
sign_keypair_internal 4s 3s +33%
sign_signature_extmu 4s 4s +0%
sign_verify 4s 4s +0%
sign_verify_extmu 4s 3s +33%
unpack_pk_t1 4s 3s +33%
unpack_sk 4s 3s +33%
yvec_get_poly 4s 4s +0%
fqscale 3s 4s -25%
intt_native_x86_64 3s 2s +50%
keccak_f1600_x4_native_aarch64_v84a 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 3s 4s -25%
keccak_f1600_x4_native_avx2 3s 3s +0%
keccak_finalize 3s 4s -25%
keccak_init 3s 1s +200%
keccakf1600_permute 3s 1s +200%
keccakf1600_xor_bytes (big endian) 3s 1s +200%
keccakf1600x4_extract_bytes 3s 3s +0%
keccakf1600x4_permute 3s 2s +50%
keccakf1600x4_xor_bytes 3s 4s -25%
keccakf1600x4_xor_bytes_native 3s 3s +0%
make_hint 3s 3s +0%
mld_ct_sel_int32 3s 4s -25%
mld_polymat_expand_entry 3s 2s +50%
mld_prepare_domain_separation_prefix 3s 5s -40%
nttunpack_native_x86_64 3s 3s +0%
pack_sig_c 3s 2s +50%
pack_sig_h 3s 3s +0%
pack_sk_rho_key_tr_s2 3s 5s -40%
pointwise_native_aarch64 3s 4s -25%
poly_chknorm_native_aarch64 3s 4s -25%
poly_chknorm_native_x86_64 3s 3s +0%
poly_decompose_88_native_aarch64 3s 2s +50%
poly_invntt_tomont_native 3s 3s +0%
poly_ntt 3s 3s +0%
poly_permute_bitrev_to_custom_optional 3s 4s -25%
poly_uniform_eta 3s 3s +0%
poly_uniform_gamma1 3s 5s -40%
polyt0_pack 3s 3s +0%
polyvec_matrix_expand_serial 3s 3s +0%
polyveck_pack_w1 3s 2s +50%
polyvecl_pack_eta 3s 2s +50%
polyvecl_pointwise_acc_montgomery_c 3s 3s +0%
polyvecl_unpack_eta 3s 3s +0%
polyw1_pack 3s 5s -40%
polyw1_pack_88 3s 4s -25%
polyz_pack 3s 5s -40%
polyz_unpack 3s 2s +50%
polyz_unpack_17_native_aarch64 3s 4s -25%
polyz_unpack_native 3s 2s +50%
reduce32 3s 2s +50%
rej_eta 3s 3s +0%
rej_eta_native 3s 5s -40%
shake128_finalize 3s 5s -40%
shake128x4_absorb_once 3s 3s +0%
shake256x4_absorb_once 3s 2s +50%
sign_signature_pre_hash_internal 3s 3s +0%
sys_check_capability 3s 4s -25%
unpack_sk_s1hat 3s 1s +200%
use_hint 3s 5s -40%
caddq 2s 1s +100%
decompose 2s 4s -50%
keccak_f1600_x1_native_aarch64_v84a 2s 3s -33%
keccak_squeeze 2s 2s +0%
keccakf1600_extract_bytes (big endian) 2s 4s -50%
keccakf1600_xor_bytes 2s 2s +0%
keccakf1600x4_extract_bytes_native 2s 1s +100%
mld_ct_abs_i32 2s 3s -33%
mld_ct_cmask_neg_i32 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 3s -33%
mld_ct_get_optblocker_i64 2s 1s +100%
mld_ct_get_optblocker_u32 2s 2s +0%
mld_ct_get_optblocker_u8 2s 2s +0%
mld_keccakf1600_extract_bytes 2s 3s -33%
mld_keccakf1600x4_extract_bytes_c 2s 2s +0%
mld_keccakf1600x4_xor_bytes_c 2s 2s +0%
mld_value_barrier_u8 2s 2s +0%
montgomery_reduce 2s 5s -60%
pack_sig_z 2s 3s -33%
poly_caddq 2s 2s +0%
poly_caddq_native_aarch64 2s 2s +0%
poly_decompose 2s 3s -33%
poly_decompose_32_native_aarch64 2s 2s +0%
poly_ntt_native 2s 4s -50%
poly_permute_bitrev_to_custom_optional_native 2s 3s -33%
poly_pointwise_montgomery 2s 3s -33%
poly_uniform_gamma1_4x 2s 4s -50%
poly_use_hint_native 2s 4s -50%
polyeta_pack 2s 3s -33%
polyt1_pack 2s 3s -33%
polyvec_matrix_expand 2s 3s -33%
polyveck_pack_eta 2s 3s -33%
polyvecl_pointwise_acc_montgomery 2s 2s +0%
polyvecl_pointwise_acc_montgomery_native 2s 2s +0%
polyvecl_uniform_gamma1 2s 3s -33%
polyz_unpack_native_x86_64 2s 4s -50%
power2round 2s 2s +0%
rej_uniform_eta_native_aarch64 2s 3s -33%
rej_uniform_native_aarch64 2s 5s -60%
shake128_absorb 2s 3s -33%
shake128_squeeze 2s 3s -33%
shake128x4_squeezeblocks 2s 2s +0%
shake256_absorb 2s 4s -50%
shake256_release 2s 4s -50%
shake256x4_squeezeblocks 2s 2s +0%
sign_signature 2s 3s -33%
sk_s2hat_get_poly 2s 5s -60%
sk_t0hat_get_poly 2s 2s +0%
unpack_sk_s2hat 2s 3s -33%
yvec_init 2s 4s -50%
keccak_f1600_x1_native_aarch64 1s 2s -50%
mld_value_barrier_u32 1s 2s -50%
shake128_release 1s 3s -67%
shake256 1s 3s -67%
shake256_init 1s 3s -67%
shake256_squeeze 1s 3s -67%
sk_s1hat_get_poly 1s 3s -67%
unpack_sk_t0hat 1s 5s -80%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-65)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 1997s 1844s +8.3%
polyvecl_pointwise_acc_montgomery_c 268s 234s +15%
sign_verify_internal 186s 177s +5%
poly_pointwise_montgomery_c 145s 132s +10%
mld_invntt_layer 127s 113s +12%
polyvec_matrix_expand 113s 111s +2%
mld_attempt_signature_generation 68s 64s +6%
sign_signature_internal 61s 59s +3%
mld_ntt_layer 47s 43s +9%
fqmul 44s 42s +5%
polyvec_matrix_expand_serial 32s 31s +3%
mld_ntt_butterfly_block 24s 20s +20%
keccakf1600x4_permute_native 22s 23s -4%
poly_ntt_c 22s 18s +22%
polyvec_matrix_pointwise_montgomery_yvec 21s 19s +11%
poly_chknorm_c 18s 16s +12%
rej_uniform_c 18s 16s +12%
polyt0_unpack 17s 15s +13%
mld_check_pct 15s 14s +7%
polyveck_decompose 15s 14s +7%
compute_pack_t0_t1 14s 14s +0%
polyz_unpack_c 14s 12s +17%
rej_uniform 14s 15s -7%
poly_uniform_4x 13s 14s -7%
poly_invntt_tomont_c 12s 14s -14%
poly_uniform_eta_4x 11s 11s +0%
mld_compute_pack_z 9s 8s +12%
poly_add 9s 7s +29%
polyveck_invntt_tomont 9s 8s +12%
keccak_absorb_once_x4 8s 8s +0%
mld_keccakf1600_permute_c 8s 6s +33%
polyeta_unpack 8s 6s +33%
polyveck_caddq 8s 6s +33%
polyveck_ntt 8s 7s +14%
sign_pk_from_sk 8s 8s +0%
ntt_native_aarch64 7s 6s +17%
sign_keypair_internal 7s 7s +0%
sign_verify_pre_hash_internal 7s 5s +40%
poly_decompose_32_native_aarch64 6s 5s +20%
poly_uniform_eta 6s 5s +20%
poly_use_hint_c 6s 5s +20%
polyt1_unpack 6s 8s -25%
polyvecl_chknorm 6s 4s +50%
polyvecl_pack_eta 6s 3s +100%
rej_uniform_native 6s 3s +100%
sign_verify 6s 2s +200%
sign_verify_extmu 6s 3s +100%
sign_verify_pre_hash_shake256 6s 3s +100%
keccakf1600x4_permute 5s 1s +400%
mld_sample_s1_s2 5s 5s +0%
mld_sample_s1_s2_serial 5s 5s +0%
ntt_native_x86_64 5s 4s +25%
pointwise_acc_native_aarch64 5s 5s +0%
pointwise_acc_native_x86_64 5s 8s -38%
poly_caddq_native_x86_64 5s 4s +25%
poly_chknorm_native 5s 2s +150%
poly_chknorm_native_x86_64 5s 4s +25%
poly_decompose_88_native_aarch64 5s 3s +67%
poly_decompose_c 5s 4s +25%
poly_pointwise_montgomery 5s 2s +150%
poly_pointwise_montgomery_native 5s 3s +67%
poly_power2round 5s 2s +150%
poly_use_hint_native 5s 4s +25%
polyvecl_ntt 5s 6s -17%
polyvecl_pointwise_acc_montgomery_native 5s 3s +67%
rej_eta 5s 3s +67%
rej_eta_native 5s 2s +150%
rej_uniform_eta_native_aarch64 5s 4s +25%
shake256_release 5s 3s +67%
shake256_squeeze 5s 3s +67%
sign_signature_extmu 5s 5s +0%
unpack_sk 5s 3s +67%
unpack_sk_t0hat 5s 4s +25%
caddq 4s 4s +0%
intt_native_aarch64 4s 2s +100%
keccak_absorb 4s 4s +0%
keccak_finalize 4s 1s +300%
keccak_squeezeblocks_x4 4s 3s +33%
keccakf1600_xor_bytes (big endian) 4s 4s +0%
mld_ct_cmask_nonzero_u32 4s 4s +0%
mld_h 4s 3s +33%
mld_keccakf1600_extract_bytes 4s 2s +100%
mld_polymat_expand_entry 4s 1s +300%
mld_prepare_domain_separation_prefix 4s 6s -33%
pack_sig_c 4s 4s +0%
pack_sk_s1 4s 3s +33%
pointwise_native_aarch64 4s 5s -20%
poly_caddq_native_aarch64 4s 3s +33%
poly_chknorm 4s 4s +0%
poly_invntt_tomont 4s 2s +100%
poly_invntt_tomont_native 4s 5s -20%
poly_reduce 4s 4s +0%
poly_uniform_gamma1 4s 4s +0%
poly_use_hint 4s 2s +100%
polyt0_pack 4s 4s +0%
polyveck_chknorm 4s 5s -20%
polyveck_pack_eta 4s 2s +100%
polyveck_reduce 4s 6s -33%
polyveck_unpack_eta 4s 3s +33%
polyvecl_pointwise_acc_montgomery 4s 1s +300%
polyvecl_unpack_z 4s 4s +0%
polyz_unpack 4s 2s +100%
polyz_unpack_19_native_aarch64 4s 3s +33%
rej_uniform_native_aarch64 4s 3s +33%
shake128x4_squeezeblocks 4s 3s +33%
shake256x4_squeezeblocks 4s 3s +33%
sign_signature 4s 5s -20%
sign_signature_pre_hash_internal 4s 3s +33%
sign_signature_pre_hash_shake256 4s 2s +100%
unpack_sk_s2hat 4s 3s +33%
use_hint 4s 5s -20%
decompose 3s 4s -25%
keccak_f1600_x4_native_aarch64_v84a 3s 2s +50%
keccak_f1600_x4_native_avx2 3s 2s +50%
keccak_init 3s 3s +0%
keccak_squeeze 3s 3s +0%
keccakf1600_extract_bytes (big endian) 3s 2s +50%
keccakf1600x4_extract_bytes 3s 2s +50%
keccakf1600x4_xor_bytes_native 3s 1s +200%
make_hint 3s 2s +50%
mld_ct_get_optblocker_i64 3s 5s -40%
mld_ct_get_optblocker_u8 3s 1s +200%
mld_keccakf1600x4_xor_bytes_c 3s 2s +50%
mld_value_barrier_u32 3s 1s +200%
mld_value_barrier_u8 3s 2s +50%
poly_caddq 3s 4s -25%
poly_caddq_native 3s 3s +0%
poly_challenge 3s 4s -25%
poly_chknorm_native_aarch64 3s 4s -25%
poly_decompose 3s 3s +0%
poly_ntt 3s 3s +0%
poly_ntt_native 3s 4s -25%
poly_permute_bitrev_to_custom_optional 3s 3s +0%
poly_permute_bitrev_to_custom_optional_native 3s 3s +0%
poly_shiftl 3s 4s -25%
poly_uniform 3s 4s -25%
poly_uniform_gamma1_4x 3s 5s -40%
polyeta_pack 3s 3s +0%
polyvec_matrix_pointwise_montgomery_row 3s 2s +50%
polyvecl_uniform_gamma1 3s 2s +50%
polyvecl_uniform_gamma1_serial 3s 3s +0%
polyvecl_unpack_eta 3s 3s +0%
polyw1_pack_32 3s 4s -25%
polyw1_pack_88 3s 2s +50%
polyz_unpack_17_native_aarch64 3s 3s +0%
polyz_unpack_native 3s 3s +0%
reduce32 3s 2s +50%
shake128_absorb 3s 4s -25%
shake128_finalize 3s 2s +50%
shake128_squeeze 3s 3s +0%
sig_unpack_hints 3s 3s +0%
sign_keypair 3s 3s +0%
sys_check_capability 3s 3s +0%
unpack_pk_t1 3s 3s +0%
yvec_init 3s 5s -40%
fqscale 2s 2s +0%
intt_native_x86_64 2s 3s -33%
keccak_f1600_x1_native_aarch64 2s 5s -60%
keccak_f1600_x1_native_aarch64_v84a 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 2s 2s +0%
keccakf1600_permute_native 2s 3s -33%
keccakf1600_xor_bytes 2s 4s -50%
keccakf1600x4_extract_bytes_native 2s 1s +100%
keccakf1600x4_xor_bytes 2s 1s +100%
mld_ct_abs_i32 2s 2s +0%
mld_ct_cmask_neg_i32 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 6s -67%
mld_ct_get_optblocker_u32 2s 1s +100%
mld_ct_memcmp 2s 2s +0%
mld_ct_sel_int32 2s 2s +0%
mld_keccakf1600x4_extract_bytes_c 2s 3s -33%
montgomery_reduce 2s 5s -60%
nttunpack_native_x86_64 2s 4s -50%
pack_sig_h 2s 1s +100%
pack_sig_z 2s 4s -50%
pack_sk_rho_key_tr_s2 2s 4s -50%
pointwise_native_x86_64 2s 4s -50%
poly_caddq_c 2s 4s -50%
poly_decompose_native 2s 2s +0%
poly_sub 2s 2s +0%
poly_use_hint_native_aarch64 2s 2s +0%
polyt1_pack 2s 2s +0%
polyveck_pack_w1 2s 4s -50%
polyw1_pack 2s 4s -50%
polyz_pack 2s 3s -33%
polyz_unpack_native_x86_64 2s 3s -33%
rej_eta_c 2s 2s +0%
shake128_release 2s 1s +100%
shake256 2s 2s +0%
shake256_absorb 2s 2s +0%
shake256_finalize 2s 1s +100%
shake256_init 2s 3s -33%
sk_s1hat_get_poly 2s 4s -50%
sk_s2hat_get_poly 2s 3s -33%
sk_t0hat_get_poly 2s 4s -50%
unpack_sk_s1hat 2s 2s +0%
yvec_get_poly 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 1s 3s -67%
keccakf1600_permute 1s 3s -67%
mld_value_barrier_i64 1s 4s -75%
power2round 1s 2s -50%
shake128_init 1s 1s +0%
shake128x4_absorb_once 1s 3s -67%
shake256x4_absorb_once 1s 1s +0%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-44)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 1576s 1621s -2.8%
polyvecl_pointwise_acc_montgomery_c 145s 155s -6%
poly_pointwise_montgomery_c 123s 136s -10%
sign_verify_internal 120s 124s -3%
mld_invntt_layer 110s 112s -2%
mld_attempt_signature_generation 58s 63s -8%
compute_pack_t0_t1 49s 51s -4%
mld_ntt_layer 43s 44s -2%
fqmul 41s 43s -5%
polyvec_matrix_expand 28s 27s +4%
sign_signature_internal 25s 23s +9%
mld_ntt_butterfly_block 23s 23s +0%
keccakf1600x4_permute_native 22s 22s +0%
poly_ntt_c 21s 18s +17%
mld_check_pct 17s 14s +21%
polyeta_unpack 17s 15s +13%
poly_chknorm_c 15s 17s -12%
polyvec_matrix_pointwise_montgomery_yvec 15s 20s -25%
rej_uniform_c 15s 15s +0%
poly_uniform_4x 14s 14s +0%
polyt0_unpack 14s 14s +0%
rej_uniform 14s 15s -7%
poly_invntt_tomont_c 13s 14s -7%
poly_uniform_eta_4x 11s 11s +0%
polyz_unpack_c 11s 13s -15%
keccak_absorb_once_x4 9s 10s -10%
polyvec_matrix_expand_serial 9s 9s +0%
polyvecl_chknorm 9s 15s -40%
mld_keccakf1600_permute_c 8s 9s -11%
poly_caddq 8s 2s +300%
mld_compute_pack_z 7s 7s +0%
mld_keccakf1600x4_xor_bytes_c 7s 4s +75%
fqscale 6s 1s +500%
pointwise_acc_native_x86_64 6s 8s -25%
poly_chknorm_native_x86_64 6s 2s +200%
poly_decompose 6s 4s +50%
polyveck_caddq 6s 5s +20%
sign_verify 6s 3s +100%
intt_native_aarch64 5s 3s +67%
intt_native_x86_64 5s 3s +67%
keccak_absorb 5s 4s +25%
keccak_squeezeblocks_x4 5s 3s +67%
keccakf1600_permute 5s 4s +25%
mld_ct_memcmp 5s 4s +25%
mld_value_barrier_u8 5s 2s +150%
ntt_native_aarch64 5s 2s +150%
pack_sig_c 5s 3s +67%
poly_add 5s 5s +0%
poly_decompose_32_native_aarch64 5s 4s +25%
poly_decompose_c 5s 4s +25%
poly_decompose_native 5s 3s +67%
polyt0_pack 5s 4s +25%
polyveck_decompose 5s 4s +25%
polyveck_ntt 5s 4s +25%
polyvecl_ntt 5s 2s +150%
rej_eta_c 5s 4s +25%
rej_uniform_native 5s 5s +0%
sign_verify_extmu 5s 5s +0%
sign_verify_pre_hash_shake256 5s 5s +0%
unpack_pk_t1 5s 2s +150%
unpack_sk_t0hat 5s 3s +67%
keccak_f1600_x1_native_aarch64 4s 3s +33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 4s 3s +33%
keccak_finalize 4s 1s +300%
keccakf1600_extract_bytes (big endian) 4s 3s +33%
mld_ct_cmask_nonzero_u8 4s 3s +33%
mld_ct_sel_int32 4s 2s +100%
mld_keccakf1600_extract_bytes 4s 2s +100%
mld_prepare_domain_separation_prefix 4s 2s +100%
mld_value_barrier_u32 4s 4s +0%
montgomery_reduce 4s 3s +33%
nttunpack_native_x86_64 4s 2s +100%
pointwise_acc_native_aarch64 4s 8s -50%
pointwise_native_aarch64 4s 5s -20%
poly_caddq_native_aarch64 4s 3s +33%
poly_challenge 4s 6s -33%
poly_ntt 4s 2s +100%
poly_permute_bitrev_to_custom_optional_native 4s 3s +33%
poly_shiftl 4s 3s +33%
poly_sub 4s 3s +33%
poly_uniform 4s 2s +100%
poly_uniform_eta 4s 5s -20%
poly_uniform_gamma1_4x 4s 5s -20%
poly_use_hint 4s 3s +33%
poly_use_hint_c 4s 3s +33%
poly_use_hint_native 4s 6s -33%
polyvec_matrix_pointwise_montgomery_row 4s 2s +100%
polyveck_chknorm 4s 2s +100%
polyveck_pack_w1 4s 2s +100%
polyvecl_pointwise_acc_montgomery_native 4s 3s +33%
polyvecl_uniform_gamma1 4s 3s +33%
polyz_unpack_17_native_aarch64 4s 3s +33%
shake256_absorb 4s 4s +0%
shake256x4_squeezeblocks 4s 1s +300%
sign_keypair_internal 4s 5s -20%
sign_signature 4s 3s +33%
sign_signature_extmu 4s 3s +33%
sign_signature_pre_hash_internal 4s 6s -33%
sign_signature_pre_hash_shake256 4s 5s -20%
sign_verify_pre_hash_internal 4s 3s +33%
unpack_sk_s1hat 4s 1s +300%
use_hint 4s 3s +33%
caddq 3s 2s +50%
keccak_f1600_x4_native_aarch64_v84a 3s 5s -40%
keccak_f1600_x4_native_avx2 3s 1s +200%
mld_ct_cmask_nonzero_u32 3s 6s -50%
mld_ct_get_optblocker_u32 3s 1s +200%
mld_ct_get_optblocker_u8 3s 6s -50%
mld_h 3s 5s -40%
mld_polymat_expand_entry 3s 3s +0%
mld_sample_s1_s2 3s 5s -40%
mld_sample_s1_s2_serial 3s 3s +0%
ntt_native_x86_64 3s 2s +50%
pack_sig_h 3s 4s -25%
pack_sig_z 3s 3s +0%
pointwise_native_x86_64 3s 4s -25%
poly_caddq_native 3s 4s -25%
poly_decompose_88_native_aarch64 3s 4s -25%
poly_invntt_tomont 3s 3s +0%
poly_ntt_native 3s 2s +50%
poly_pointwise_montgomery 3s 4s -25%
poly_pointwise_montgomery_native 3s 3s +0%
poly_power2round 3s 3s +0%
poly_reduce 3s 4s -25%
poly_uniform_gamma1 3s 4s -25%
poly_use_hint_native_aarch64 3s 2s +50%
polyeta_pack 3s 3s +0%
polyt1_pack 3s 3s +0%
polyt1_unpack 3s 6s -50%
polyveck_invntt_tomont 3s 5s -40%
polyveck_unpack_eta 3s 2s +50%
polyvecl_pointwise_acc_montgomery 3s 3s +0%
polyvecl_unpack_eta 3s 3s +0%
polyvecl_unpack_z 3s 3s +0%
polyw1_pack 3s 2s +50%
polyz_unpack 3s 4s -25%
polyz_unpack_native_x86_64 3s 4s -25%
power2round 3s 3s +0%
rej_eta 3s 4s -25%
rej_uniform_eta_native_aarch64 3s 3s +0%
rej_uniform_native_aarch64 3s 4s -25%
shake128_finalize 3s 3s +0%
shake128_squeeze 3s 3s +0%
shake128x4_absorb_once 3s 2s +50%
shake128x4_squeezeblocks 3s 2s +50%
shake256 3s 5s -40%
shake256_init 3s 2s +50%
sign_keypair 3s 3s +0%
sign_pk_from_sk 3s 7s -57%
sk_s1hat_get_poly 3s 2s +50%
unpack_sk 3s 2s +50%
keccak_f1600_x1_native_aarch64_v84a 2s 4s -50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 2s 2s +0%
keccak_init 2s 5s -60%
keccak_squeeze 2s 4s -50%
keccakf1600_permute_native 2s 4s -50%
keccakf1600_xor_bytes 2s 2s +0%
keccakf1600_xor_bytes (big endian) 2s 3s -33%
keccakf1600x4_extract_bytes 2s 3s -33%
keccakf1600x4_permute 2s 2s +0%
keccakf1600x4_xor_bytes 2s 3s -33%
keccakf1600x4_xor_bytes_native 2s 2s +0%
make_hint 2s 5s -60%
mld_ct_cmask_neg_i32 2s 2s +0%
mld_ct_get_optblocker_i64 2s 3s -33%
pack_sk_rho_key_tr_s2 2s 1s +100%
pack_sk_s1 2s 4s -50%
poly_caddq_c 2s 3s -33%
poly_caddq_native_x86_64 2s 3s -33%
poly_chknorm 2s 7s -71%
poly_chknorm_native 2s 4s -50%
poly_chknorm_native_aarch64 2s 2s +0%
poly_invntt_tomont_native 2s 4s -50%
poly_permute_bitrev_to_custom_optional 2s 2s +0%
polyveck_pack_eta 2s 3s -33%
polyvecl_pack_eta 2s 2s +0%
polyw1_pack_32 2s 3s -33%
polyw1_pack_88 2s 3s -33%
polyz_pack 2s 4s -50%
polyz_unpack_19_native_aarch64 2s 3s -33%
polyz_unpack_native 2s 3s -33%
rej_eta_native 2s 4s -50%
shake128_absorb 2s 3s -33%
shake128_init 2s 4s -50%
shake128_release 2s 2s +0%
shake256_finalize 2s 2s +0%
shake256x4_absorb_once 2s 3s -33%
sk_t0hat_get_poly 2s 2s +0%
sys_check_capability 2s 4s -50%
unpack_sk_s2hat 2s 3s -33%
yvec_init 2s 2s +0%
decompose 1s 3s -67%
keccakf1600x4_extract_bytes_native 1s 3s -67%
mld_ct_abs_i32 1s 1s +0%
mld_keccakf1600x4_extract_bytes_c 1s 4s -75%
mld_value_barrier_i64 1s 3s -67%
polyveck_reduce 1s 3s -67%
polyvecl_uniform_gamma1_serial 1s 4s -75%
reduce32 1s 4s -75%
shake256_release 1s 1s +0%
shake256_squeeze 1s 2s -50%
sig_unpack_hints 1s 1s +0%
sk_s2hat_get_poly 1s 2s -50%
yvec_get_poly 1s 2s -50%

@oqs-bot

oqs-bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CBMC Results (ML-DSA-87)

Full Results (203 proofs)
Proof Status Current Previous Change
**TOTAL** 2010s 2190s -8.2%
polyvecl_pointwise_acc_montgomery_c 340s 366s -7%
polyvec_matrix_expand 300s 310s -3%
poly_pointwise_montgomery_c 128s 137s -7%
mld_invntt_layer 107s 118s -9%
sign_verify_internal 100s 104s -4%
mld_attempt_signature_generation 54s 57s -5%
mld_ntt_layer 44s 47s -6%
sign_signature_internal 41s 41s +0%
fqmul 39s 44s -11%
polyvec_matrix_expand_serial 35s 40s -12%
keccakf1600x4_permute_native 22s 23s -4%
mld_ntt_butterfly_block 22s 25s -12%
poly_ntt_c 19s 22s -14%
compute_pack_t0_t1 18s 19s -5%
polyeta_unpack 16s 17s -6%
polyvec_matrix_pointwise_montgomery_yvec 16s 19s -16%
poly_chknorm_c 15s 17s -12%
polyt0_unpack 15s 17s -12%
rej_uniform 15s 17s -12%
rej_uniform_c 13s 15s -13%
poly_uniform_4x 12s 12s +0%
poly_uniform_eta_4x 12s 13s -8%
mld_check_pct 11s 17s -35%
polyveck_decompose 11s 12s -8%
poly_invntt_tomont_c 10s 12s -17%
polyveck_ntt 10s 9s +11%
mld_compute_pack_z 9s 10s -10%
keccak_absorb_once_x4 8s 11s -27%
mld_keccakf1600_permute_c 8s 7s +14%
polyveck_caddq 8s 7s +14%
polyvecl_ntt 8s 9s -11%
pointwise_acc_native_aarch64 7s 8s -12%
pointwise_acc_native_x86_64 7s 7s +0%
polyveck_invntt_tomont 7s 10s -30%
unpack_sk_t0hat 7s 6s +17%
fqscale 6s 3s +100%
mld_sample_s1_s2_serial 6s 5s +20%
poly_add 6s 9s -33%
poly_challenge 6s 4s +50%
poly_decompose_c 6s 5s +20%
poly_uniform_gamma1_4x 6s 4s +50%
rej_uniform_eta_native_aarch64 6s 5s +20%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid 5s 3s +67%
keccak_squeeze 5s 3s +67%
keccakf1600x4_extract_bytes 5s 2s +150%
keccakf1600x4_extract_bytes_native 5s 3s +67%
mld_sample_s1_s2 5s 6s -17%
poly_decompose_88_native_aarch64 5s 3s +67%
poly_use_hint_native 5s 3s +67%
polyveck_unpack_eta 5s 5s +0%
polyvecl_pointwise_acc_montgomery_native 5s 2s +150%
rej_eta_c 5s 5s +0%
rej_eta_native 5s 4s +25%
sign_keypair_internal 5s 7s -29%
sign_pk_from_sk 5s 5s +0%
sign_signature 5s 3s +67%
sign_signature_pre_hash_shake256 5s 3s +67%
sign_verify_extmu 5s 5s +0%
sign_verify_pre_hash_internal 5s 4s +25%
decompose 4s 3s +33%
keccak_f1600_x4_native_avx2 4s 1s +300%
keccak_init 4s 2s +100%
keccak_squeezeblocks_x4 4s 4s +0%
keccakf1600x4_xor_bytes_native 4s 3s +33%
make_hint 4s 3s +33%
mld_prepare_domain_separation_prefix 4s 4s +0%
nttunpack_native_x86_64 4s 3s +33%
pack_sk_rho_key_tr_s2 4s 4s +0%
poly_caddq 4s 5s -20%
poly_caddq_c 4s 2s +100%
poly_permute_bitrev_to_custom_optional 4s 2s +100%
poly_power2round 4s 3s +33%
poly_shiftl 4s 2s +100%
poly_uniform 4s 2s +100%
polyt1_unpack 4s 6s -33%
polyveck_chknorm 4s 5s -20%
polyveck_reduce 4s 2s +100%
polyvecl_chknorm 4s 5s -20%
polyvecl_pointwise_acc_montgomery 4s 5s -20%
polyvecl_unpack_eta 4s 3s +33%
polyvecl_unpack_z 4s 4s +0%
polyw1_pack_32 4s 3s +33%
polyw1_pack_88 4s 3s +33%
polyz_pack 4s 2s +100%
polyz_unpack_native_x86_64 4s 5s -20%
rej_eta 4s 1s +300%
rej_uniform_native 4s 4s +0%
shake128_init 4s 2s +100%
shake128_squeeze 4s 3s +33%
intt_native_aarch64 3s 5s -40%
intt_native_x86_64 3s 4s -25%
keccak_absorb 3s 4s -25%
keccakf1600_permute_native 3s 3s +0%
keccakf1600_xor_bytes (big endian) 3s 5s -40%
keccakf1600x4_permute 3s 2s +50%
keccakf1600x4_xor_bytes 3s 3s +0%
mld_ct_sel_int32 3s 3s +0%
mld_h 3s 3s +0%
mld_keccakf1600x4_xor_bytes_c 3s 3s +0%
mld_polymat_expand_entry 3s 2s +50%
mld_value_barrier_i64 3s 4s -25%
ntt_native_aarch64 3s 5s -40%
ntt_native_x86_64 3s 6s -50%
pack_sig_c 3s 3s +0%
pack_sig_h 3s 5s -40%
pointwise_native_aarch64 3s 3s +0%
poly_caddq_native 3s 3s +0%
poly_chknorm 3s 3s +0%
poly_chknorm_native_x86_64 3s 3s +0%
poly_decompose 3s 6s -50%
poly_decompose_32_native_aarch64 3s 2s +50%
poly_decompose_native 3s 3s +0%
poly_invntt_tomont_native 3s 6s -50%
poly_ntt 3s 2s +50%
poly_ntt_native 3s 4s -25%
poly_pointwise_montgomery_native 3s 5s -40%
poly_uniform_eta 3s 4s -25%
poly_use_hint 3s 4s -25%
poly_use_hint_c 3s 3s +0%
poly_use_hint_native_aarch64 3s 3s +0%
polyeta_pack 3s 2s +50%
polyt0_pack 3s 3s +0%
polyvec_matrix_pointwise_montgomery_row 3s 3s +0%
polyveck_pack_eta 3s 4s -25%
polyvecl_pack_eta 3s 5s -40%
polyvecl_uniform_gamma1_serial 3s 5s -40%
polyz_unpack_17_native_aarch64 3s 2s +50%
polyz_unpack_19_native_aarch64 3s 5s -40%
reduce32 3s 4s -25%
shake128_absorb 3s 3s +0%
shake128x4_absorb_once 3s 1s +200%
shake256 3s 2s +50%
shake256_finalize 3s 2s +50%
shake256x4_absorb_once 3s 5s -40%
shake256x4_squeezeblocks 3s 4s -25%
sig_unpack_hints 3s 3s +0%
sign_keypair 3s 4s -25%
sign_signature_extmu 3s 3s +0%
sign_signature_pre_hash_internal 3s 8s -62%
sign_verify 3s 3s +0%
sign_verify_pre_hash_shake256 3s 4s -25%
sk_s1hat_get_poly 3s 4s -25%
sk_s2hat_get_poly 3s 4s -25%
unpack_pk_t1 3s 3s +0%
yvec_get_poly 3s 3s +0%
yvec_init 3s 6s -50%
keccak_f1600_x1_native_aarch64 2s 3s -33%
keccak_f1600_x1_native_aarch64_v84a 2s 1s +100%
keccak_f1600_x4_native_aarch64_v84a 2s 4s -50%
keccak_finalize 2s 2s +0%
keccakf1600_extract_bytes (big endian) 2s 2s +0%
mld_ct_cmask_neg_i32 2s 3s -33%
mld_ct_cmask_nonzero_u32 2s 3s -33%
mld_ct_cmask_nonzero_u8 2s 5s -60%
mld_ct_get_optblocker_i64 2s 5s -60%
mld_ct_get_optblocker_u32 2s 5s -60%
mld_keccakf1600_extract_bytes 2s 3s -33%
mld_value_barrier_u32 2s 2s +0%
mld_value_barrier_u8 2s 1s +100%
pack_sig_z 2s 2s +0%
pack_sk_s1 2s 6s -67%
pointwise_native_x86_64 2s 2s +0%
poly_caddq_native_aarch64 2s 2s +0%
poly_caddq_native_x86_64 2s 1s +100%
poly_permute_bitrev_to_custom_optional_native 2s 3s -33%
poly_reduce 2s 4s -50%
poly_sub 2s 4s -50%
poly_uniform_gamma1 2s 3s -33%
polyt1_pack 2s 2s +0%
polyveck_pack_w1 2s 4s -50%
polyvecl_uniform_gamma1 2s 3s -33%
polyw1_pack 2s 2s +0%
polyz_unpack 2s 5s -60%
polyz_unpack_c 2s 4s -50%
polyz_unpack_native 2s 2s +0%
power2round 2s 5s -60%
rej_uniform_native_aarch64 2s 3s -33%
shake128_finalize 2s 3s -33%
shake128_release 2s 2s +0%
shake256_absorb 2s 6s -67%
shake256_init 2s 3s -33%
shake256_release 2s 2s +0%
sk_t0hat_get_poly 2s 3s -33%
unpack_sk 2s 4s -50%
unpack_sk_s1hat 2s 4s -50%
unpack_sk_s2hat 2s 5s -60%
use_hint 2s 3s -33%
caddq 1s 2s -50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid 1s 4s -75%
keccakf1600_permute 1s 2s -50%
keccakf1600_xor_bytes 1s 2s -50%
mld_ct_abs_i32 1s 3s -67%
mld_ct_get_optblocker_u8 1s 3s -67%
mld_ct_memcmp 1s 1s +0%
mld_keccakf1600x4_extract_bytes_c 1s 4s -75%
montgomery_reduce 1s 4s -75%
poly_chknorm_native 1s 4s -75%
poly_chknorm_native_aarch64 1s 3s -67%
poly_invntt_tomont 1s 2s -50%
poly_pointwise_montgomery 1s 2s -50%
shake128x4_squeezeblocks 1s 3s -67%
shake256_squeeze 1s 5s -80%
sys_check_capability 1s 4s -75%

Comment thread test/src/test_mldsa.c Outdated
Comment on lines +214 to +215
MLD_CT_TESTING_DECLASSIFY(&rc, sizeof(rc));
MLD_CT_TESTING_DECLASSIFY(&siglen, sizeof(siglen));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't those declassifications are necessary? Those values should be public already, I believe.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I missed that during my review. I'll go ahead and remove them.

Comment thread test/src/test_mldsa.c Outdated
Comment on lines +202 to +205
CHECK(randombytes(ph1, sizeof(ph1)) == 0);
MLD_CT_TESTING_SECRET(ph1, sizeof(ph1));
CHECK(randombytes(ph2, sizeof(ph2)) == 0);
MLD_CT_TESTING_SECRET(ph2, sizeof(ph2));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the tests exercising ph1 vs. ph2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No difference. I'll go ahead and make this one test for signing and one for verification.

Comment thread mldsa/mldsa_native.h Outdated
Comment on lines +635 to +640
* MLD_PREHASH_SHA2_512, MLD_PREHASH_SHA2_512_224, MLD_PREHASH_SHA2_512_256,
* MLD_PREHASH_SHA3_224, MLD_PREHASH_SHA3_256, MLD_PREHASH_SHA3_384,
* MLD_PREHASH_SHA3_512, MLD_PREHASH_SHAKE_128, MLD_PREHASH_SHAKE_256.
* MLD_PREHASH_NONE is rejected by this HashML-DSA API.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This is still indented under the Supported hash algorithm constants: block.

Suggestion:

Suggested change
* MLD_PREHASH_NONE is rejected by this HashML-DSA API.
* Supported hash algorithm constants:
* MLD_PREHASH_SHA2_224, MLD_PREHASH_SHA2_256, MLD_PREHASH_SHA2_384,
* MLD_PREHASH_SHA2_512, MLD_PREHASH_SHA2_512_224, MLD_PREHASH_SHA2_512_256,
* MLD_PREHASH_SHA3_224, MLD_PREHASH_SHA3_256, MLD_PREHASH_SHA3_384,
* MLD_PREHASH_SHA3_512, MLD_PREHASH_SHAKE_128, MLD_PREHASH_SHAKE_256.
*
* MLD_PREHASH_NONE is rejected by this API.

@hanno-becker hanno-becker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fegge, I support this change.

Minor nit regarding the documentation, and I believe the test can be simplified -- see comments.

Signed-off-by: Fredrik Dahlgren <fredrik.dahlgren@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prehash API accepts MLD_PREHASH_NONE and ignores the digest

3 participants