Add mixed BC heat conduction test cases#845
Closed
vidulejs wants to merge 5 commits into
Closed
Conversation
1 task
Member
|
These tutorials were mostly meant as test cases for features of the OpenFOAM adapter (and I asked @vidulejs to quickly open this PR to have them available). Since these are variants of existing tutorials that mainly relate to the OpenFOAM adapter configuration, and since that configuration will eventually become the standard, I prefer to not merge this PR, but keep it as a test case. I might reopen this PR in the future. We have now integrated these tutorials as test cases sourced directly from your fork in #732, included in the nightly I am closing this PR, but please do not delete the fork and the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted from the partitioned-heat-conduction tutorial case. The only real changes are the interface boundary conditions (0/T), system/preciceDict, and precice-config.xml. The remaining files were copied from the base tutorial.
TODO: Summarize and motivate the changes, link to issues, remove the checklist entries that are not relevant.
Checklist
changelog-entries/<PRnumber>.md.For new tutorials or tutorial cases:
README.mdmetadata.yamltools/tests/tests.yaml_config.yaml