Skip to content

fix(deploy): accept collocated reference uploader upgrades - #808

Open
proerror77 wants to merge 1 commit into
mainfrom
codex/reference-collocated-uploader
Open

fix(deploy): accept collocated reference uploader upgrades#808
proerror77 wants to merge 1 commit into
mainfrom
codex/reference-collocated-uploader

Conversation

@proerror77

@proerror77 proerror77 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Change contract

Allow a Binance USD-M Reference release produced by this cutover to pass the next upgrade preflight. The old uploader must be collocated with the previous collector release, and its release sidecar plus actual binary SHA-256 must match before any runtime transition starts. The receipt keeps the previous collector release SHA and actual uploader SHA; the obsolete standalone uploader-release field was removed after a full-repo search found no consumer.

Issue relationship

None

Out of scope

  • No production host, service, symlink, spool, or OSS mutation.
  • No manual migration of the current uploader path.
  • No new installer or Cloud Assistant invoker.
  • The feat(collector): publish per-modality PIT clocks in USD-M reference manifest v2 #803 Reference V2 runtime rollout requires a separate runtime issue with exact candidate, rollback identity, controller, stop rules, and readback after this code is merged and republished.

Dependencies and merge order

None

Focused validation

  • deployment/aliyun/test-binance-usdm-reference-release-contract.sh
  • deployment/aliyun/test-binance-usdm-reference-shadow-gate.sh
  • deployment/aliyun/test-binance-usdm-reference-host-gate.sh
  • bash -n deployment/aliyun/binance-usdm-reference-cutover.sh deployment/aliyun/test-binance-usdm-reference-host-gate.sh
  • shellcheck deployment/aliyun/binance-usdm-reference-cutover.sh deployment/aliyun/test-binance-usdm-reference-host-gate.sh
  • git diff --check
  • Counterexamples: a standalone legacy uploader path is rejected; a collocated uploader whose bytes drift from its sidecar is rejected; an uploader sidecar rejected by the trust validator is rejected.
  • Contract assertion: previous_uploader_release_sha256 is absent and previous_uploader_sha256 remains bound to the actual old uploader bytes.
  • Two independent diff reviews: no blocking findings; final review approved with zero findings.

The repository preflight script itself exits 141 with the current 190+ worktrees because its git worktree list | awk ... exit pipeline trips pipefail; the same checks with the consumer draining the full worktree list returned verdict=ok. This PR does not alter that unrelated script.

Rollout and rollback

Code-only change; production was not touched. After merge, publish a new exact-head artifact before opening the separate #803 runtime rollout. Roll back this code by reverting the PR before any candidate staging.

Scope exception

None

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 238c6d94-140f-425f-951f-233053448f9a

📥 Commits

Reviewing files that changed from the base of the PR and between f679d51 and 3c6624e.

📒 Files selected for processing (2)
  • deployment/aliyun/binance-usdm-reference-cutover.sh
  • deployment/aliyun/test-binance-usdm-reference-host-gate.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 force-pushed the codex/reference-collocated-uploader branch 3 times, most recently from baa9ec4 to 310f90a Compare August 10, 2026 13:35
@proerror77
proerror77 force-pushed the codex/reference-collocated-uploader branch from 310f90a to 3c6624e Compare August 13, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant