fix(collector): heal Polymarket recovered market context - #880
Conversation
|
Warning Review limit reached
Next review available in: 110 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMarket-detail recovery now includes markets without end times, prioritizes them, and continues bounded processing without an invalid-end-time completeness failure. A regression test verifies deferred-market rotation across planning passes. ChangesPolymarket recovery
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Merge Risk: ⚪ Minimal · up to This localized recovery change keeps invalid recovered markets eligible for bounded healing while preserving fail-closed health behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acc8629dad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change
Recovered markets with a missing or invalid end time now enter the bounded authoritative market-detail queue. Their health remains fail-closed through
invalid_end_time_markets, but the collector stays alive so the rotating queue can heal the backlog instead of restarting before it advances.Issue relationship
None
Validation
cargo test -p hft-collector --locked polymarket_raw(92 passed, 2 ignored)cargo test -p hft-collector --locked missing_end_time_recovery_is_bounded_and_rotates_backlogcargo clippy -p hft-collector --locked --all-targets -- -D warningsgit diff --checkcargo fmt -p hft-collector -- --checkremains unavailable because the current pinned formatter reports unrelated existing diffs across the crate; the changed hunk is not reformatted broadly.Runtime impact and rollback
Production is currently contained with the Polymarket reference collector stopped after its 6-hour restart exposed this recovery crash loop. The release candidate will first be exercised against a CoW copy of the frozen production tape and state. Rollback is the prior immutable binary and untouched production spool; no tape is deleted or rewritten by this PR.
Summary by CodeRabbit