Harden API JSON validation paths#137
Merged
ralyodio merged 2 commits intoJul 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Hardens several API routes so malformed or non-object JSON returns a clear 400 instead of falling into deeper route logic.
Covered routes:
src/app/api/auth/debug-sms/route.jssrc/app/api/conversations/create/route.jssrc/app/api/files/upload-url/route.jssrc/app/api/files/upload-complete/route.jsAlso adds focused regression tests for the validation paths.
Why
These are small QA hardening fixes for request validation. Invalid JSON/body shapes should fail at the boundary and avoid confusing downstream behavior.
Validation
npx vitest run src/app/api/files/upload-url/route.test.js src/app/api/files/upload-complete/route.test.js src/app/api/conversations/create/route.test.js --reporter=dotnode --checkon changed route/test filesgit diff --check